Bug 41724 – Improve XHR access control tests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Justin Schuh]

Improve XHR access control tests

[Justin Schuh]

Created attachment 60664 [details]
Patch

[Justin Schuh]

Improving and expanding the layout tests added with the fix for bug 36483.

[Adam Barth]

Comment on attachment 60664 [details]
Patch

LayoutTests/http/tests/xmlhttprequest/access-control-preflight-async-not-supported.html:10
 +  if (window.layoutTestController) {
No braces needed.

LayoutTests/http/tests/xmlhttprequest/access-control-preflight-async-not-supported.html:19
 +          xhr.send("");
Usually we pass null for GET (no body) instead of a body of length 0.

LayoutTests/http/tests/xmlhttprequest/access-control-preflight-async-not-supported.html:56
 +          // Eat the exception.
Why don't we log it?

[Adam Barth]

Those comments were just drive-bys.  ap should probably review your patch since he requested it.

[Justin Schuh]

(In reply to comment #3)
> (From update of attachment 60664 [details])
> LayoutTests/http/tests/xmlhttprequest/access-control-preflight-async-not-supported.html:56
>  +          // Eat the exception.
> Why don't we log it?

The exception here means the test probably succeeded (because we want the request to be denied). But I'm doing a more thorough result check in the onreadystatechange handler, which also validates that the server side matches what it should be. 

And I'll fix the style issues and resubmit.

[Alexey Proskuryakov]

Comment on attachment 60664 [details]
Patch

Clearing review flag per the above comment.

Looks good to me. Do these tests pass in Firefox?

This change makes it obvious that I called "header field" a "header" at least once. I'll need to fix that eventually.

[David Levin]

(In reply to comment #2)
> Improving and expanding the layout tests added with the fix for bug 36483.

I don't think that is the right bug number: "webkitpy: Move the commands folder into webkitpy/patch"

[Justin Schuh]

(In reply to comment #7)
> (In reply to comment #2)
> > Improving and expanding the layout tests added with the fix for bug 36483.
> 
> I don't think that is the right bug number: "webkitpy: Move the commands folder into webkitpy/patch"

Dyslexia strikes again. Sorry, that should be bug 36843. I've finally gotten through my holiday weekend backlog so I should be posting a cleaned up patch shortly.

[Justin Schuh]

Created attachment 60811 [details]
Patch

Cleaned up style issues and tweaked a few things so the tests will run in Firefox.

[WebKit Commit Bot]

Comment on attachment 60811 [details]
Patch

Clearing flags on attachment: 60811

Committed r62779: <http://trac.webkit.org/changeset/62779>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.