Bug 41710 - [GTK] Crashes when going back with page cache in unknown circunstances
Summary: [GTK] Crashes when going back with page cache in unknown circunstances
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2010-07-06 12:10 PDT by Gustavo Noronha (kov)
Modified: 2010-07-12 07:35 PDT (History)
1 user (show)

See Also:


Attachments
stack trace (18.36 KB, text/plain)
2010-07-06 12:11 PDT, Gustavo Noronha (kov)
no flags Details
stack trace for a different crash (9.98 KB, patch)
2010-07-09 11:44 PDT, Gustavo Noronha (kov)
no flags Details | Formatted Diff | Diff
One more null-check (1.60 KB, patch)
2010-07-09 11:50 PDT, Gustavo Noronha (kov)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2010-07-06 12:10:30 PDT
After we enabled page cache for our port, we found a number of crashes, and unwanted behavior that were caused by our unique scrolling implementation (we try to be as close to what GTK+ expects, which not always maps well to WebCore's expectations, which is why we have quite a bit of platform-specific code). After fixing a number of these, one crash still appears in bug reports fairly frequently. I am attaching a trace.
Comment 1 Gustavo Noronha (kov) 2010-07-06 12:11:49 PDT
Created attachment 60651 [details]
stack trace
Comment 2 Gustavo Noronha (kov) 2010-07-06 12:12:59 PDT
Since we haven't been able to reproduce consistently reproduce this crash, and the traces make it fairly credible that document is NULL, I landed a null check as 62546.
Comment 3 Gustavo Noronha (kov) 2010-07-09 11:44:25 PDT
Created attachment 61068 [details]
stack trace for a different crash
Comment 4 Gustavo Noronha (kov) 2010-07-09 11:50:23 PDT
Created attachment 61070 [details]
One more null-check
Comment 5 Gustavo Noronha (kov) 2010-07-09 11:51:04 PDT
I'll reuse this bug, since it is tightly related to the other fix that points here.
Comment 6 Xan Lopez 2010-07-12 06:27:25 PDT
Comment on attachment 61070 [details]
One more null-check

OK, hope this one is enough.
Comment 7 Gustavo Noronha (kov) 2010-07-12 07:34:42 PDT
Comment on attachment 61070 [details]
One more null-check

Landed as r63082. Now to try and fix this in a better way.