Bug 41709 - DOM plug-in related renames
Summary: DOM plug-in related renames
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-06 11:24 PDT by Anders Carlsson
Modified: 2010-07-14 11:32 PDT (History)
4 users (show)

See Also:

Attachments
Patch (70.78 KB, patch)
2010-07-06 11:26 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (72.22 KB, patch)
2010-07-06 11:50 PDT, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-07-06 11:24:01 PDT 
DOM plug-in related renames
Comment 1 Anders Carlsson 2010-07-06 11:26:51 PDT 
Created attachment 60646 [details]
Patch
Comment 2 WebKit Review Bot 2010-07-06 11:28:46 PDT 
Attachment 60646 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/page/Navigator.h:30:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2010-07-06 11:36:18 PDT 
Attachment 60646 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/3369370
Comment 4 Sam Weinig 2010-07-06 11:42:58 PDT 
Comment on attachment 60646 [details]
Patch

I like the renames, but this is going to break tests.
Comment 5 Anders Carlsson 2010-07-06 11:50:27 PDT 
Created attachment 60649 [details]
Patch
Comment 6 WebKit Review Bot 2010-07-06 11:52:51 PDT 
Attachment 60649 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/page/Navigator.h:30:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Review Bot 2010-07-06 12:28:38 PDT 
http://trac.webkit.org/changeset/62577 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, and Qt Linux ARMv7 Release
Comment 8 Anders Carlsson 2010-07-14 11:32:01 PDT 
Committed r62577: <http://trac.webkit.org/changeset/62577>