Bug 41704 - [GTK] build-webkit should not run autogen.sh unconditionally
Summary: [GTK] build-webkit should not run autogen.sh unconditionally
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-06 10:32 PDT by Martin Robinson
Modified: 2010-07-06 10:45 PDT (History)
0 users

See Also:


Attachments
Patch (2.76 KB, patch)
2010-07-06 10:33 PDT, Martin Robinson
xan.lopez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-07-06 10:32:02 PDT
Currently build-webkit runs autogen.sh always. The makefiles that autotools generates should be smart enough to know when the originally build files have been modified and re-rerun autogen.sh. On my machine, this change reduces a null build from 60 seconds to 14 seconds.
Comment 1 Martin Robinson 2010-07-06 10:33:53 PDT
Created attachment 60637 [details]
Patch
Comment 2 Xan Lopez 2010-07-06 10:37:34 PDT
Comment on attachment 60637 [details]
Patch

Looks good to me!
Comment 3 Martin Robinson 2010-07-06 10:45:36 PDT
Committed r62564: <http://trac.webkit.org/changeset/62564>