Web Inspector: script names are shown with ":0"
Created attachment 60630 [details] Proposed patch.
Comment on attachment 60630 [details] Proposed patch. Clearing flags on attachment: 60630 Committed r62575: <http://trac.webkit.org/changeset/62575>
All reviewed patches have been landed. Closing bug.
Comment on attachment 60630 [details] Proposed patch. WebCore/bindings/v8/ScriptDebugServer.cpp:383 + object->Get(v8::String::New("lineOffset"))->ToInteger()->Value() + 1, This should be done in DebuggerScript.js using DebuggerScript._v8ToWebkitLineNumber. Please fix this in a separate change.
There isn't really any such thing as a "webkit line number". Line numbers are a mess. The code is sprinkled with all sorts of +1's, not all of which make sense. Search for lineNumber() to see what I mean.
(In reply to comment #5) > There isn't really any such thing as a "webkit line number". Line numbers are a mess. The code is sprinkled with all sorts of +1's, not all of which make sense. > > Search for lineNumber() to see what I mean. In case of debugger we try to localize line number arithmetic related to v8(script line numbers start from 0)/WebCore(script line numbers are assumed to start from 1) in DebuggerScript.js
The question is where you get the line number from in WebCore. I think the parser starts at 0, but ScriptController/JavaScriptCore start at 1. Someone needs to straighten this all out some day.