RESOLVED FIXED 41696
Web Inspector: script names are shown with ":0" 
https://bugs.webkit.org/show_bug.cgi?id=41696
Summary Web Inspector: script names are shown with ":0"
Pavel Podivilov
Reported 2010-07-06 07:04:28 PDT
Web Inspector: script names are shown with ":0"
Attachments
Proposed patch. (1.39 KB, patch)
2010-07-06 07:06 PDT, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2010-07-06 07:06:44 PDT
Created attachment 60630 [details] Proposed patch.
WebKit Commit Bot
Comment 2 2010-07-06 11:52:19 PDT
Comment on attachment 60630 [details] Proposed patch. Clearing flags on attachment: 60630 Committed r62575: <http://trac.webkit.org/changeset/62575>
WebKit Commit Bot
Comment 3 2010-07-06 11:52:24 PDT
All reviewed patches have been landed. Closing bug.
Yury Semikhatsky
Comment 4 2010-07-07 02:44:27 PDT
Comment on attachment 60630 [details] Proposed patch. WebCore/bindings/v8/ScriptDebugServer.cpp:383 + object->Get(v8::String::New("lineOffset"))->ToInteger()->Value() + 1, This should be done in DebuggerScript.js using DebuggerScript._v8ToWebkitLineNumber. Please fix this in a separate change.
Eric Seidel (no email)
Comment 5 2010-07-07 02:49:42 PDT
There isn't really any such thing as a "webkit line number". Line numbers are a mess. The code is sprinkled with all sorts of +1's, not all of which make sense. Search for lineNumber() to see what I mean.
Yury Semikhatsky
Comment 6 2010-07-07 02:55:08 PDT
(In reply to comment #5) > There isn't really any such thing as a "webkit line number". Line numbers are a mess. The code is sprinkled with all sorts of +1's, not all of which make sense. > > Search for lineNumber() to see what I mean. In case of debugger we try to localize line number arithmetic related to v8(script line numbers start from 0)/WebCore(script line numbers are assumed to start from 1) in DebuggerScript.js
Eric Seidel (no email)
Comment 7 2010-07-07 03:25:39 PDT
The question is where you get the line number from in WebCore. I think the parser starts at 0, but ScriptController/JavaScriptCore start at 1. Someone needs to straighten this all out some day.
Note You need to log in before you can comment on or make changes to this bug.