Bug 41692 – Web Inspector: generator part of of the patch for bug 40675

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Ilya Tikhonovsky]

https://bugs.webkit.org/show_bug.cgi?id=40675

As far as the patch was quite big. It was split and this bug is created for generator related changes.

--------
On the way to Remote Debuging we want to support JSON serialization on both sides of WebInspector transport.
As far as InspectorFrontend class is a simple proxy to WebInspector it would be better to generate it from an IDL file.
We have generator infostructure for binding and will reuse it for new generator.
--------

[Ilya Tikhonovsky]

Created attachment 60626 [details]
[patch] initial version.

[Yury Semikhatsky]

Comment on attachment 60626 [details]
[patch] initial version.

 +          WebInspector: generator part of of the patch for bug 40675.
of of -> of here and in other ChangeLogs

Clear Main Comment Box:6
 +          On the way to Remote Debuging we want to support JSON serialization
Debuging  -> Debugging  here and in other ChangeLogs

Please land it manually and watch the bots.

[WebKit Review Bot]

Attachment 60626 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/3366372

[Joseph Pecoraro]

Looks like this was landed in:
http://trac.webkit.org/changeset/62549

There was a build fix in:
http://trac.webkit.org/changeset/62552

EFL build fix:
http://trac.webkit.org/changeset/62571

Ilya, if this is complete (and you have privileges) you can mark the
bug as resolved.

Nice work! My only comment on the patch would be that the
ChangeLog should contain more information, especially given that
there are new files.

[Ilya Tikhonovsky]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	ChangeLog
	M	GNUmakefile.am
	M	WebCore/CMakeLists.txt
	M	WebCore/ChangeLog
	M	WebCore/DerivedSources.make
	M	WebCore/GNUmakefile.am
	M	WebCore/WebCore.gyp/WebCore.gyp
	M	WebCore/WebCore.gyp/scripts/rule_binding.py
	M	WebCore/WebCore.gypi
	M	WebCore/WebCore.pri
	M	WebCore/WebCore.vcproj/WebCore.vcproj
	M	WebCore/WebCore.xcodeproj/project.pbxproj
	M	WebCore/bindings/scripts/CodeGenerator.pm
	M	WebCore/bindings/scripts/IDLParser.pm
	M	WebCore/bindings/scripts/generate-bindings.pl
	A	WebCore/inspector/CodeGeneratorInspector.pm
	M	WebCore/inspector/InspectorController.cpp
	M	WebCore/inspector/InspectorController.h
	M	WebCore/inspector/InspectorFrontend.cpp
	M	WebCore/inspector/InspectorFrontend.h
	A	WebCore/inspector/InspectorFrontend2.idl
	M	WebCore/inspector/InspectorTimelineAgent.cpp
	M	WebCore/inspector/InspectorTimelineAgent.h
Committed r62549