Bug 41685 - DeviceOrientationEventConstructor should be exposed at window.DeviceOrientationEvent
Summary: DeviceOrientationEventConstructor should be exposed at window.DeviceOrientati...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 30335
  Show dependency tree / graph
 
Reported: 2010-07-06 03:58 PDT by Steve Block
Modified: 2010-07-07 04:52 PDT (History)
3 users (show)

See Also:

Attachments
Patch (16.41 KB, patch)
2010-07-06 04:08 PDT, Steve Block 		abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-07-06 03:58:32 PDT 
This matches other event types.
Comment 1 Steve Block 2010-07-06 04:08:04 PDT 
Created attachment 60616 [details]
Patch
Comment 2 Adam Barth 2010-07-07 03:16:28 PDT 
Comment on attachment 60616 [details]
Patch

The code looks right.  A couple questions about the tests.

LayoutTests/fast/dom/Window/window-properties-device-orientation.html:34
 +      if (typeof value == "object" && value == null) //;
Why "//;" here?

LayoutTests/fast/dom/Window/window-properties.html:86
 +      "window.DeviceOrientationEvent" : 1,
Why skip this?
Comment 3 Steve Block 2010-07-07 04:24:27 PDT 
> LayoutTests/fast/dom/Window/window-properties-device-orientation.html:34
>  +      if (typeof value == "object" && value == null) //;
> Why "//;" here?
No reason. This was copied from window-properties.html. Will remove before landing.

> LayoutTests/fast/dom/Window/window-properties.html:86
>  +      "window.DeviceOrientationEvent" : 1,
> Why skip this?
DeviceOrientation isn't enabled on all platforms, so we don't test it here, but instead test it in window-properties-device-orientation.html, which platforms can choose to skip.
Comment 4 Steve Block 2010-07-07 04:52:29 PDT 
Committed r62653: <http://trac.webkit.org/changeset/62653>