Bug 41679 – [Qt] REGRESSION (r62511): 64-bit build is broken

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: JavaScriptCore

[Csaba Osztrogonác]

They don't exist on Linux:
#include <mach/mach_init.h>
#include <mach/vm_map.h>

arc4random() function is available only on bsd based systems by default.
On Linux, you have to install libbsd-dev package to use arc4random(). I 
think it isn't a good idea to add a new dependency because of this function.

[Csaba Osztrogonác]

Created attachment 60611 [details]
Patch

[Gabor Loki]

And what about QtWebKit on MAC? It satisfy both requirements - the includes and the arc4random function. (I guess the original change was induced by a bug or a limitation on Mac.

In additional this patch will not fix the Gtk-64 which will have the same error (if the current include problem is fixed).

[Adam Barth]

Comment on attachment 60611 [details]
Patch

I'm all for build fixes, but the second part of your diff looks like a bit of copy/paste.  Is there a better way of structuring the #ifdefs to just target the arc4random part?

[Csaba Osztrogonác]

Comment on attachment 60611 [details]
Patch

This fix is obsolete, because the original patch was rolled-out.

Gavin, could you fix this issue too when you land the fixed
patch in https://bugs.webkit.org/show_bug.cgi?id=41641 ?

[Gavin Barraclough]

Resolved (hopefully) as a part of relanding initial patch.

*** This bug has been marked as a duplicate of bug 41641 ***