Add new WebKitTestRunner project for Windows. bug 41086 was for mac.
Created attachment 60590 [details] patch
Attachment 60590 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKitTools/WebKitTestRunner/win/TestControllerWin.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKitTools/WebKitTestRunner/win/PlatformWebViewWin.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKitTools/WebKitTestRunner/win/TestInvocationWin.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKitTools/WebKitTestRunner/win/main.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 4 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Attachment 60590 [details] did not pass style-queue: hrm, I'm confused. I don't think I want to include config.h. That causes build problems.
(In reply to comment #3) > (In reply to comment #2) > > Attachment 60590 [details] [details] did not pass style-queue: > > hrm, I'm confused. I don't think I want to include config.h. That causes build problems. Yeah. Ignore that.
Comment on attachment 60590 [details] patch > Reviewed by Eric Seidel. > Index: WebKitTools/WebKitTestRunner/WebKitTestRunnerPrefix.h > =================================================================== > --- WebKitTools/WebKitTestRunner/WebKitTestRunnerPrefix.h (revision 62511) > +++ WebKitTools/WebKitTestRunner/WebKitTestRunnerPrefix.h (working copy) > @@ -27,4 +27,9 @@ > #include <Cocoa/Cocoa.h> > #endif > > +// If we don't define these, they get defined in windef.h. > +// We want to use std::min and std::max > +#define max max > +#define min min I think these probably want to be behind a #if PLATFORM(WIN) or some such. Otherwise, r=me.
http://trac.webkit.org/changeset/62825