Bug 41620 – Web Inspector: preserve scroll positions in source frame when switching between panes.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Patch to follow.

[Pavel Feldman]

Created attachment 60549 [details]
[PATCH] Proposed fix.

[Joseph Pecoraro]

Comment on attachment 60549 [details]
[PATCH] Proposed fix.

> +++ b/WebCore/inspector/front-end/SourceFrame.js
> +        if (visible) {
> +            if (this._textViewer && this._scrollTop)
> +                this._textViewer.element.scrollTop = this._scrollTop;
> +            if (this._textViewer && this._scrollLeft)
> +                this._textViewer.element.scrollLeft = this._scrollLeft;
> +        } else {

You could have prevented a duplicate check by doing an if (this._textViewer)
block like you already do in the else.

>              this._hidePopup();
> -            if (this._textViewer)
> +            if (this._textViewer) {
> +                this._scrollTop = this._textViewer.element.scrollTop;
> +                this._scrollLeft = this._textViewer.element.scrollLeft;
>                  this._textViewer.freeCachedElements();
> +            }

There is a call to this._createViewerIfNeeded above this if/else. I
think that would have created a viewer in this case so that this
check wouldn't be necessary, but I think its good to be safe.


Thanks!

[WebKit Commit Bot]

Comment on attachment 60549 [details]
[PATCH] Proposed fix.

Clearing flags on attachment: 60549

Committed r62496: <http://trac.webkit.org/changeset/62496>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.