Bug 41618 - document.createEvent() should support DeviceOrientationEvent
Summary: document.createEvent() should support DeviceOrientationEvent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 30335
  Show dependency treegraph
 
Reported: 2010-07-05 09:19 PDT by Steve Block
Modified: 2010-07-07 06:59 PDT (History)
6 users (show)

See Also:


Attachments
Patch 1 (5.29 KB, patch)
2010-07-06 03:36 PDT, Steve Block
no flags Details | Formatted Diff | Diff
Patch 2 (5.29 KB, patch)
2010-07-06 04:06 PDT, Steve Block
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-07-05 09:19:49 PDT
document.createEvent() should support DeviceOrientationEvent
Comment 1 Steve Block 2010-07-06 03:36:01 PDT
Created attachment 60612 [details]
Patch 1
Comment 2 Early Warning System Bot 2010-07-06 03:43:28 PDT
Attachment 60612 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/3405285
Comment 3 WebKit Review Bot 2010-07-06 03:54:00 PDT
Attachment 60612 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/3384310
Comment 4 Steve Block 2010-07-06 04:06:27 PDT
Created attachment 60615 [details]
Patch 2
Comment 5 Adam Barth 2010-07-07 03:20:46 PDT
Comment on attachment 60615 [details]
Patch 2

Thanks for breaking these changes into small pieces.
Comment 6 WebKit Commit Bot 2010-07-07 06:59:08 PDT
Comment on attachment 60615 [details]
Patch 2

Clearing flags on attachment: 60615

Committed r62659: <http://trac.webkit.org/changeset/62659>
Comment 7 WebKit Commit Bot 2010-07-07 06:59:13 PDT
All reviewed patches have been landed.  Closing bug.