Bug 41612 - REGRESSION(r60652): WebKitTools/Scripts/ensure-valid-python should cleanup temporary directory
Summary: REGRESSION(r60652): WebKitTools/Scripts/ensure-valid-python should cleanup te...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 39058
  Show dependency treegraph
 
Reported: 2010-07-05 07:08 PDT by Csaba Osztrogonác
Modified: 2010-07-05 23:29 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.38 KB, patch)
2010-07-05 07:13 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2010-07-05 07:08:49 PDT
Now WebKitTools/Scripts/ensure-valid-python generates one more 
/tmp/XXXXXXXX file again and again on my linux machine.

I propose the following change:
-my $tempDirectory = File::Temp->tempdir("WebKitPythonXXXX");
+my $tempDirectory = File::Temp::tempdir("WebKitPythonXXXX", TMPDIR => 1, CLEANUP => 1);
Comment 1 Csaba Osztrogonác 2010-07-05 07:13:01 PDT
Created attachment 60527 [details]
Patch
Comment 2 Fumitoshi Ukai 2010-07-05 18:19:32 PDT
Comment on attachment 60527 [details]
Patch

LGTM
Comment 3 Eric Seidel (no email) 2010-07-05 23:15:56 PDT
I don't really know what this does.
Comment 4 Csaba Osztrogonác 2010-07-05 23:29:18 PDT
Comment on attachment 60527 [details]
Patch

Clearing flags on attachment: 60527

Committed r62526: <http://trac.webkit.org/changeset/62526>
Comment 5 Csaba Osztrogonác 2010-07-05 23:29:26 PDT
All reviewed patches have been landed.  Closing bug.