This is consistent with other controllers, eg Geolocation, and will allow the name DeviceOrientation to be used to represent a set of device orientation data. This will be cleaner than passing around the 3 bools and 3 doubles required to represent the optional properties of the DeviceOrientationEvent.
Created attachment 60532 [details] Patch
This sounds good to me. Only found one issue: In WebCore/page/Page.h: > - DeviceOrientation* deviceOrientation() const { return m_deviceOrientation.get(); } > + DeviceOrientationController* deviceOrientationController() const { return m_deviceOrientation.get(); } I guess this should return m_deviceOrientationController.get()?
Created attachment 60539 [details] Patch
Comment on attachment 60539 [details] Patch WebCore/dom/DeviceOrientationController.h:38 + // FIXME: Add methods to start and stop the service. This patch will make more sense once we do this FIXME. It's not really controlling the DeviceOrientation, is it? That would be kind of awesome. Instead, it's controlling the DeviceOrientation service, right? I guess the GeolocationController isn't controlling the geolocation either. I guess brevity is a virtue here and DeviceOrientationServiceController is too long... Anyway, not 100% cheesed about the name.
Committed r62646: <http://trac.webkit.org/changeset/62646>