Bug 41597 – Don't pass image hash to DRT when pixel tests are disabled

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Gabor Rapcsanyi]

new-run-webkit-tests shouldn't pass image hash to DRT when pixel tests are disabled.

[Gabor Rapcsanyi]

Created attachment 60510 [details]
proposed patch

[Eric Seidel (no email)]

Comment on attachment 60510 [details]
proposed patch

Does this match old-run-webkit-tests?  Why is Qt the only port which has noticed this? (Because other ports aren't using NRWT much yet?)

[Gabor Rapcsanyi]

(In reply to comment #2)
> (From update of attachment 60510 [details])
> Does this match old-run-webkit-tests?  Why is Qt the only port which has noticed this? (Because other ports aren't using NRWT much yet?)

Yes, this behavior matches old-run-webkit-tests. Seems other ports don't use new-run-webkit-tests yet. The image hash is only used by pixel tests.

[Csaba Osztrogonác]

(In reply to comment #2)
> (From update of attachment 60510 [details])
> Does this match old-run-webkit-tests?  Why is Qt the only port which has noticed this? (Because other ports aren't using NRWT much yet?)

ORWT only pass hash to DRT if pixel tests is enabled:
------
    # Try to read expected hash file for pixel tests
    my $suffixExpectedHash = "";
    if ($pixelTests && !$resetResults) {
        my $expectedPixelDir = expectedDirectoryForTest($base, 0, "png");
        if (open EXPECTEDHASH, "$expectedPixelDir/$base-$expectedTag.checksum") {
            my $expectedHash = <EXPECTEDHASH>;
            chomp($expectedHash);
            close EXPECTEDHASH;

            # Format expected hash into a suffix string that is appended to the path / URL passed to DRT
            $suffixExpectedHash = "'$expectedHash";
        }
    }
------

[Eric Seidel (no email)]

Comment on attachment 60510 [details]
proposed patch

OK.  I suspect this is a regression since last time I tried NRWT then, since --platform=mac had pixel tests disabled when we were last using NRWT with it.

[WebKit Commit Bot]

Comment on attachment 60510 [details]
proposed patch

Clearing flags on attachment: 60510

Committed r62541: <http://trac.webkit.org/changeset/62541>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.