Steps: 1. Run "./WebKitTools/Scripts/build-dumprendertree" to have ImageDiff 2. Prepend "REABSELINE" to a line of "BUG48154 WIN LINUX: fast/forms/indeterminate.html = IMAGE" 3. Run "./WebKitTools/Scripts/rebaseline-chromium-webkit-tests -w" Expected result: No error. Actual result: 100705 12:27:18 rebaseline_chromium_webkit_tests.py:176 INFO Html directory: "/var/folders/zz/zzzivhrRnAmviuee++0u7E++iWI/-Tmp-/tmpaEpx44/rebaseline_html" 100705 12:27:18 rebaseline_chromium_webkit_tests.py:981 INFO 100705 12:27:18 rebaseline_chromium_webkit_tests.py:154 INFO --------------------------- Rebaseline started: mac --------------------------- 100705 12:27:18 rebaseline_chromium_webkit_tests.py:154 INFO ---------------------- Compiling rebaselining tests: mac ---------------------- 100705 12:27:18 rebaseline_chromium_webkit_tests.py:297 WARNING No tests found that need rebaselining. 100705 12:27:18 rebaseline_chromium_webkit_tests.py:154 INFO ----------------------------- Rebaseline done: mac ----------------------------- 100705 12:27:18 rebaseline_chromium_webkit_tests.py:981 INFO 100705 12:27:18 rebaseline_chromium_webkit_tests.py:154 INFO --------------------------- Rebaseline started: win --------------------------- 100705 12:27:18 rebaseline_chromium_webkit_tests.py:154 INFO ---------------------- Compiling rebaselining tests: win ---------------------- 100705 12:27:18 rebaseline_chromium_webkit_tests.py:302 INFO Total number of tests needing rebaselining for "win": "1" 100705 12:27:18 rebaseline_chromium_webkit_tests.py:306 INFO 1: fast/forms/indeterminate.html ------------------------- 100705 12:27:19 rebaseline_chromium_webkit_tests.py:334 INFO Latest revision: "51623" 100705 12:27:19 rebaseline_chromium_webkit_tests.py:379 INFO Archive url: "http://build.chromium.org/buildbot/layout_test_results/webkit-rel-webkit-org/51623/layout-test-results.zip" 100705 12:27:22 rebaseline_chromium_webkit_tests.py:395 INFO Archive downloaded and saved to file: "/var/folders/zz/zzzivhrRnAmviuee++0u7E++iWI/-Tmp-/tmpNDL4Cl.zip" 100705 12:27:22 rebaseline_chromium_webkit_tests.py:254 INFO 100705 12:27:22 rebaseline_chromium_webkit_tests.py:154 INFO ------------------- Extracting and adding new baselines: win ------------------- 100705 12:27:22 rebaseline_chromium_webkit_tests.py:423 INFO Test 1: fast/forms/indeterminate.html 100705 12:27:22 rebaseline_chromium_webkit_tests.py:434 INFO .txt file not in archive. 100705 12:27:22 rebaseline_chromium_webkit_tests.py:438 INFO .png file found in archive. 100705 12:27:23 rebaseline_chromium_webkit_tests.py:620 INFO Html: copied new baseline file from "/Users/tkent/WebKit/LayoutTests/platform/chromium-win/fast/forms/indeterminate-expected.png" to "/var/folders/zz/zzzivhrRnAmviuee++0u7E++iWI/-Tmp-/tmpaEpx44/rebaseline_html/indeterminate-expected-win-new.png". Traceback (most recent call last): File "./WebKitTools/Scripts/rebaseline-chromium-webkit-tests", line 44, in <module> rebaseline_chromium_webkit_tests.main() File "/Users/tkent/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py", line 983, in main if rebaseliner.run(backup): File "/Users/tkent/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py", line 261, in run if not self._extract_and_add_new_baselines(archive_file): File "/Users/tkent/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py", line 479, in _extract_and_add_new_baselines self._create_html_baseline_files(expected_fullpath) File "/Users/tkent/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py", line 624, in _create_html_baseline_files output = self._scm.show_head(baseline_fullpath) File "/Users/tkent/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm.py", line 665, in show_head return self.run(['git', 'show', 'HEAD:' + self.to_object_name(path)]) File "/Users/tkent/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm.py", line 114, in run decode_output=decode_output) File "/Users/tkent/WebKit2/WebKitTools/Scripts/webkitpy/common/system/executive.py", line 91, in run_command File "/Users/tkent/WebKit2/WebKitTools/Scripts/webkitpy/common/system/executive.py", line 296, in run_command File "/System/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/encodings/utf_8.py", line 16, in decode return codecs.utf_8_decode(input, errors, True) UnicodeDecodeError: 'utf8' codec can't decode byte 0x89 in position 0: unexpected code byte Note: This is NOT git-specific. I had the same error with a SVN checkout and a log for that case contained return self.run(['svn', 'cat', '-r', 'BASE', path])
(In reply to comment #0) > 2. Prepend "REABSELINE" to a line of "BUG48154 WIN LINUX: fast/forms/indeterminate.html = IMAGE" typo: "REBASELINE"
Created attachment 60494 [details] patch v0
Comment on attachment 60494 [details] patch v0 Looks good.
Committed r62480: <http://trac.webkit.org/changeset/62480>