Bug 41584 - [Qt] Add DRT support for pageProperty etc.
Summary: [Qt] Add DRT support for pageProperty etc.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-07-04 13:35 PDT by Robert Hogan
Modified: 2010-07-08 13:58 PDT (History)
3 users (show)

See Also:


Attachments
Patch (9.08 KB, patch)
2010-07-04 13:38 PDT, Robert Hogan
kenneth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2010-07-04 13:35:32 PDT
Unskip:
     printing/page-rule-selection.html
     printing/page-format-data.html
Comment 1 Robert Hogan 2010-07-04 13:38:16 PDT
Created attachment 60478 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2010-07-05 14:42:04 PDT
Comment on attachment 60478 [details]
Patch

8 QString DumpRenderTreeSupportQt::pageSizeAndMarginsInPixels(QWebFrame* frame, int pageIndex,
 679                                               int width, int height,
 680                                               int marginTop,
 681                                               int marginRight,
 682                                               int marginBottom,
 683                                               int marginLeft)

This is wrong coding style, put it on one line. Apart from that r=me.
Comment 3 Robert Hogan 2010-07-08 13:58:00 PDT
Committed r62830: <http://trac.webkit.org/changeset/62830>