Bug 41581 - Add a very basic InTable insertion mode
Summary: Add a very basic InTable insertion mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on: 41453
Blocks:
  Show dependency tree / graph
 
Reported: 2010-07-04 12:23 PDT by Eric Seidel (no email)
Modified: 2010-07-04 14:56 PDT (History)
1 user (show)

See Also:

Attachments
Patch (14.76 KB, patch)
2010-07-04 12:27 PDT, Eric Seidel (no email) 		abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-07-04 12:23:25 PDT 
Add a very basic InTable insertion mode
Comment 1 Eric Seidel (no email) 2010-07-04 12:27:37 PDT 
Created attachment 60475 [details]
Patch
Comment 2 Adam Barth 2010-07-04 13:24:41 PDT 
Comment on attachment 60475 [details]
Patch

Thanks!  I looked at doing this last night, but I'm glad you did it.  :)

WebCore/html/HTMLTreeBuilder.cpp:770
 +              insertElement(token);
You want to use insertSelfClosingElement here instead.
Comment 3 Eric Seidel (no email) 2010-07-04 14:52:29 PDT 
Oh, there is lots more to do. :)  A bunch of simple changes on top of this patch would pass a whole bunch more tests (like handling "any other tag" in table mode).
Comment 4 Eric Seidel (no email) 2010-07-04 14:56:20 PDT 
Committed r62469: <http://trac.webkit.org/changeset/62469>