Bug 41565 - Repatching in ARMv7Assembler::repatchLoadPtrToLEA is broken
Summary: Repatching in ARMv7Assembler::repatchLoadPtrToLEA is broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-02 23:31 PDT by Gavin Barraclough
Modified: 2010-07-02 23:46 PDT (History)
1 user (show)

See Also:

Attachments
The patch (1.76 KB, patch)
2010-07-02 23:33 PDT, Gavin Barraclough 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2010-07-02 23:31:08 PDT 
This method tried to repatch a LDR (T2) into an ADD (T3) – but it only repatches the first instruction word.  The layout of the fields in the second word is different, and also needs repatching.
Comment 1 Gavin Barraclough 2010-07-02 23:33:25 PDT 
Created attachment 60441 [details]
The patch
Comment 2 WebKit Review Bot 2010-07-02 23:36:27 PDT 
Attachment 60441 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
JavaScriptCore/assembler/ARMv7Assembler.h:1733:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Oliver Hunt 2010-07-02 23:36:55 PDT 
Comment on attachment 60441 [details]
The patch

> +        This method tried to repatch a LDR (T2) into an ADD (T3) â but it only
â?

otherwise r=me
Comment 4 Gavin Barraclough 2010-07-02 23:46:04 PDT 
Fixed in r62437.