Bug 41540 - WebKit2: Add InjectedCode API to get a list of subframes
Summary: WebKit2: Add InjectedCode API to get a list of subframes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-02 14:21 PDT by Sam Weinig
Modified: 2010-07-02 16:01 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.31 KB, patch)
2010-07-02 14:30 PDT, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-07-02 14:21:22 PDT 
Add InjectedCode API to get a list of subframes.
Comment 1 Sam Weinig 2010-07-02 14:30:12 PDT 
Created attachment 60403 [details]
Patch
Comment 2 WebKit Review Bot 2010-07-02 14:33:25 PDT 
Attachment 60403 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/WebProcess/WebPage/WebFrame.cpp:187:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Oliver Hunt 2010-07-02 14:40:54 PDT 
Comment on attachment 60403 [details]
Patch


> +    for (Frame* child = m_coreFrame->tree()->firstChild(); child; child = child->tree()->nextSibling(), ++i) {
> +    	WebFrame* webFrame = static_cast<WebFrameLoaderClient*>(child->loader()->client())->webFrame();
tab!!!! :-O


Remove this and r=me
Comment 4 Sam Weinig 2010-07-02 16:01:48 PDT 
Fixed in http://trac.webkit.org/changeset/62406.