Bug 41537 - Some http tests fail on Windows with Cygwin 1.7
Summary: Some http tests fail on Windows with Cygwin 1.7
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Brian Weinstein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-02 13:31 PDT by Brian Weinstein
Modified: 2010-07-02 13:40 PDT (History)
1 user (show)

See Also:

Attachments
[PATCH] Fix (2.17 KB, patch)
2010-07-02 13:34 PDT, Brian Weinstein 		sfalken: review+
bweinstein: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Weinstein 2010-07-02 13:31:41 PDT 
Some http tests fail on Windows with Cygwin 1.7, because LayoutTestControllerWin::resolveCygwinPath fails, because:

DWORD result = ::SHGetValueW(HKEY_LOCAL_MACHINE, TEXT("SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/"), TEXT("native"), &keyType, &rootPath, &rootPathSize);

fails, due to a configuration change on Cygwin 1.7
Comment 1 Brian Weinstein 2010-07-02 13:34:01 PDT 
Created attachment 60399 [details]
[PATCH] Fix
Comment 2 WebKit Review Bot 2010-07-02 13:36:23 PDT 
Attachment 60399 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp:620:  Tab found; better to use spaces  [whitespace/tab] [1]
WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp:621:  Tab found; better to use spaces  [whitespace/tab] [1]
WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp:622:  Tab found; better to use spaces  [whitespace/tab] [1]
WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp:623:  Tab found; better to use spaces  [whitespace/tab] [1]
WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp:624:  Tab found; better to use spaces  [whitespace/tab] [1]
WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp:625:  Tab found; better to use spaces  [whitespace/tab] [1]
WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp:626:  Tab found; better to use spaces  [whitespace/tab] [1]
WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp:627:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 8 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brian Weinstein 2010-07-02 13:40:24 PDT 
Landed in r62400.