Bug 41527 - Adding notification and touch events methods to WebChromeClient
Summary: Adding notification and touch events methods to WebChromeClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Luiz Agostini
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-02 11:51 PDT by Luiz Agostini
Modified: 2010-07-02 20:39 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.52 KB, patch)
2010-07-02 11:55 PDT, Luiz Agostini 		sam: review-
Details | Formatted Diff | Diff
patch 2 (2.70 KB, patch)
2010-07-02 13:01 PDT, Luiz Agostini 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luiz Agostini 2010-07-02 11:51:45 PDT 
Adding notification and touch events methods to WebChromeClient
Comment 1 Luiz Agostini 2010-07-02 11:55:26 PDT 
Created attachment 60385 [details]
Patch
Comment 2 Sam Weinig 2010-07-02 12:44:13 PDT 
Comment on attachment 60385 [details]
Patch

> +
> +#if ENABLE(NOTIFICATIONS)
> +    virtual WebCore::NotificationPresenter* notificationPresenter() const { return 0; }
> +#endif
> +
> +#if ENABLE(TOUCH_EVENTS)
> +    virtual void needTouchEvents(bool) { }
> +#endif
> +

Please put the implementation in the .cpp file.

r-.
Comment 3 Luiz Agostini 2010-07-02 13:01:11 PDT 
Created attachment 60393 [details]
patch 2
Comment 4 WebKit Commit Bot 2010-07-02 20:39:29 PDT 
Comment on attachment 60393 [details]
patch 2

Clearing flags on attachment: 60393

Committed r62428: <http://trac.webkit.org/changeset/62428>
Comment 5 WebKit Commit Bot 2010-07-02 20:39:33 PDT 
All reviewed patches have been landed.  Closing bug.