RESOLVED FIXED 41527
Adding notification and touch events methods to WebChromeClient 
https://bugs.webkit.org/show_bug.cgi?id=41527
Summary Adding notification and touch events methods to WebChromeClient
Luiz Agostini
Reported 2010-07-02 11:51:45 PDT
Adding notification and touch events methods to WebChromeClient
Attachments
Patch (1.52 KB, patch)
2010-07-02 11:55 PDT, Luiz Agostini 		sam: review-
DetailsFormatted DiffDiff
patch 2 (2.70 KB, patch)
2010-07-02 13:01 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Luiz Agostini
Comment 1 2010-07-02 11:55:26 PDT
Created attachment 60385 [details] Patch
Sam Weinig
Comment 2 2010-07-02 12:44:13 PDT
Comment on attachment 60385 [details] Patch > + > +#if ENABLE(NOTIFICATIONS) > + virtual WebCore::NotificationPresenter* notificationPresenter() const { return 0; } > +#endif > + > +#if ENABLE(TOUCH_EVENTS) > + virtual void needTouchEvents(bool) { } > +#endif > + Please put the implementation in the .cpp file. r-.
Luiz Agostini
Comment 3 2010-07-02 13:01:11 PDT
Created attachment 60393 [details] patch 2
WebKit Commit Bot
Comment 4 2010-07-02 20:39:29 PDT
Comment on attachment 60393 [details] patch 2 Clearing flags on attachment: 60393 Committed r62428: <http://trac.webkit.org/changeset/62428>
WebKit Commit Bot
Comment 5 2010-07-02 20:39:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.