Bug 41524 - [BREWMP] Change the CRASH() macro to print "WebKit CRASH" log.
Summary: [BREWMP] Change the CRASH() macro to print "WebKit CRASH" log.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 33564
  Show dependency treegraph
 
Reported: 2010-07-02 11:03 PDT by Kwang Yul Seo
Modified: 2010-07-03 01:17 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.42 KB, patch)
2010-07-02 11:05 PDT, Kwang Yul Seo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-07-02 11:03:59 PDT
Print "WebKit CRASH" before crashing.
Comment 1 Kwang Yul Seo 2010-07-02 11:05:35 PDT
Created attachment 60381 [details]
Patch
Comment 2 WebKit Review Bot 2010-07-02 11:06:18 PDT
Attachment 60381 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
JavaScriptCore/wtf/Assertions.h:175:  Missing space before ( in while(  [whitespace/parens] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Kwang Yul Seo 2010-07-02 11:08:27 PDT
(In reply to comment #2)
> Attachment 60381 [details] did not pass style-queue:
> 
> Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
> JavaScriptCore/wtf/Assertions.h:175:  Missing space before ( in while(  [whitespace/parens] [5]
> Total errors found: 1 in 2 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

The patch did not pass style-queue, but actually it is consistent with other CRASH macros.
Comment 4 WebKit Commit Bot 2010-07-03 01:17:49 PDT
Comment on attachment 60381 [details]
Patch

Clearing flags on attachment: 60381

Committed r62441: <http://trac.webkit.org/changeset/62441>
Comment 5 WebKit Commit Bot 2010-07-03 01:17:54 PDT
All reviewed patches have been landed.  Closing bug.