RESOLVED FIXED 41516
JavaInstanceV8 needs to push a local reference frame to avoid table overflow. 
https://bugs.webkit.org/show_bug.cgi?id=41516
Summary JavaInstanceV8 needs to push a local reference frame to avoid table overflow.
Steve Block
Reported 2010-07-02 03:34:21 PDT
Similar to jsc's implementation, this is needed to restrict the amount of local references in a given jni frame. Once the frame is popped from the stack, all local references are cleaned.
Attachments
Patch (1.89 KB, patch)
2010-07-02 03:53 PDT, Steve Block 		no flags
DetailsFormatted DiffDiff
Patch (2.61 KB, patch)
2010-07-02 07:03 PDT, Steve Block 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2010-07-02 03:53:19 PDT
Created attachment 60356 [details] Patch
Patrick
Comment 2 2010-07-02 05:44:37 PDT
Should the LOGV be removed from JavaInstanceV8.cpp as well?
Steve Block
Comment 3 2010-07-02 07:03:20 PDT
Created attachment 60364 [details] Patch
Adam Barth
Comment 4 2010-07-07 02:39:48 PDT
Comment on attachment 60364 [details] Patch This change is taxing the boundaries of my understanding of Java. Ideally, the ChangeLog would contain more information to help folks understand what problem is being solved and how this patch goes about solving them. I'm hesitating to R+ this change, but on balance, it seems like the right thing to do. WebCore/ChangeLog:8 + No new tests. sad face WebCore/bridge/jni/v8/JavaInstanceV8.cpp:50 + #define NUM_LOCAL_REFS 64 Where does this number come from?
Steve Block
Comment 5 2010-07-07 03:28:24 PDT
Committed r62650: <http://trac.webkit.org/changeset/62650>
Note You need to log in before you can comment on or make changes to this bug.