Bug 41516 - JavaInstanceV8 needs to push a local reference frame to avoid table overflow.
Summary: JavaInstanceV8 needs to push a local reference frame to avoid table overflow.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-02 03:34 PDT by Steve Block
Modified: 2010-07-07 03:28 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.89 KB, patch)
2010-07-02 03:53 PDT, Steve Block
no flags Details | Formatted Diff | Diff
Patch (2.61 KB, patch)
2010-07-02 07:03 PDT, Steve Block
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-07-02 03:34:21 PDT
Similar to jsc's implementation, this is needed to restrict the
amount of local references in a given jni frame.  Once the frame is
popped from the stack, all local references are cleaned.
Comment 1 Steve Block 2010-07-02 03:53:19 PDT
Created attachment 60356 [details]
Patch
Comment 2 Patrick 2010-07-02 05:44:37 PDT
Should the LOGV be removed from JavaInstanceV8.cpp as well?
Comment 3 Steve Block 2010-07-02 07:03:20 PDT
Created attachment 60364 [details]
Patch
Comment 4 Adam Barth 2010-07-07 02:39:48 PDT
Comment on attachment 60364 [details]
Patch

This change is taxing the boundaries of my understanding of Java.  Ideally, the ChangeLog would contain more information to help folks understand what problem is being solved and how this patch goes about solving them.  I'm hesitating to R+ this change, but on balance, it seems like the right thing to do.

WebCore/ChangeLog:8
 +          No new tests.
sad face

WebCore/bridge/jni/v8/JavaInstanceV8.cpp:50
 +  #define NUM_LOCAL_REFS 64
Where does this number come from?
Comment 5 Steve Block 2010-07-07 03:28:24 PDT
Committed r62650: <http://trac.webkit.org/changeset/62650>