Bug 41513 – [WinCairo] Disable QT private player if GStreamer is enabled

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Philippe Normand]

It doesn't make much sense to build the QT player for WinCairo if the GStreamer player is enabled already. QuickTime is not part of the current requirements but GStreamer should soon be added.

[Philippe Normand]

Created attachment 60352 [details]
MediaPlayer: disable QT player on WinCairo

[Eric Carlson]

(In reply to comment #0)
> It doesn't make much sense to build the QT player for WinCairo if the GStreamer player is 
> enabled already. QuickTime is not part of the current requirements but GStreamer should 
> soon be added.

On the other hand, the QuickTime media engine does nothing unless the use has QuickTime installed and MediaPlayer supports having support for more than one media engine, so is there any harm in allowing someone to build in support for both QuickTime and GStreamer?

[Philippe Normand]

(In reply to comment #2)
> (In reply to comment #0)
> > It doesn't make much sense to build the QT player for WinCairo if the GStreamer player is 
> > enabled already. QuickTime is not part of the current requirements but GStreamer should 
> > soon be added.
> 
> On the other hand, the QuickTime media engine does nothing unless the use has QuickTime installed and MediaPlayer supports having support for more than one media engine, so is there any harm in allowing someone to build in support for both QuickTime and GStreamer?

Agreed it should be possible indeed. But because the current WinCairo requirements don't include QuickTime, the private mediaplayer doesn't build at all. So to be able to include the MediaPlayer.cpp file in the WinCairo build I had to make that patch :(

[Philippe Normand]

Ok I can probably provide a more explicit patch than this using PLATFORM(CAIRO) instead of USE(GSTREAMER)

[Martin Robinson]

Comment on attachment 60352 [details]
MediaPlayer: disable QT player on WinCairo

Sounds like you are working on another version of this patch? I've
cleared the review flag until you post it. If this is indeed your
final version, feel free to reflag it!

[Philippe Normand]

GStreamer has been enabled in WinCairo some time ago.