RESOLVED FIXED 41489
Make process launching asynchronous
https://bugs.webkit.org/show_bug.cgi?id=41489
Summary Make process launching asynchronous
Anders Carlsson
Reported 2010-07-01 15:02:51 PDT
Make process launching asynchronous
Attachments
Patch (36.60 KB, patch)
2010-07-01 15:12 PDT, Anders Carlsson
sam: review+
Anders Carlsson
Comment 1 2010-07-01 15:12:09 PDT
WebKit Review Bot
Comment 2 2010-07-01 15:13:10 PDT
Attachment 60294 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit2/UIProcess/Launcher/win/ProcessLauncherWin.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/UIProcess/Launcher/ProcessLauncher.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 2 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2010-07-01 15:24:52 PDT
Comment on attachment 60294 [details] Patch > + // Register ourselves. > + kern_return_t kr = bootstrap_register2(bootstrap_port, (char*)"com.apple.WebKit.WebProcess", listeningPort, /* BOOTSTRAP_PER_PID_SERVICE */ 1); > + if (kr) > + NSLog(@"bootstrap_register2 result: %x", kr); > + > + pid_t processIdentifier; > + int result = posix_spawn(&processIdentifier, path, 0, 0, (char *const*)args, *_NSGetEnviron()); > + if (result) > + NSLog(@"posix_spawn result: %d", result); Not a new issue but, should we bail on errors here? r=me.
Anders Carlsson
Comment 4 2010-07-14 11:27:37 PDT
Note You need to log in before you can comment on or make changes to this bug.