Bug 41479 - Change the CoreIPC connection identifier to be a HANDLE on Windows
Summary: Change the CoreIPC connection identifier to be a HANDLE on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-01 12:31 PDT by Anders Carlsson
Modified: 2010-07-01 13:04 PDT (History)
1 user (show)

See Also:

Attachments
Patch (13.52 KB, patch)
2010-07-01 12:36 PDT, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-07-01 12:31:36 PDT 
Change the CoreIPC connection identifier to be a HANDLE on Windows
Comment 1 Anders Carlsson 2010-07-01 12:36:59 PDT 
Created attachment 60273 [details]
Patch
Comment 2 WebKit Review Bot 2010-07-01 12:39:25 PDT 
Attachment 60273 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/WebProcess/win/WebProcessMain.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/WebProcess/win/WebProcessMain.cpp:64:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2010-07-01 13:04:37 PDT 
Committed r62290: <http://trac.webkit.org/changeset/62290>