Bug 41478 – canvas/philip/tests/2d.imageData.get.source.outside.html fails on the Mac bot

• Status: RESOLVED
• Resolution: CONFIGURATION CHANGED
• Component: WebCore Misc.

[Andreas Kling]

This test already works, thanks to the following code in getImageData:

if (rect.x() < 0 || rect.y() < 0 || (rect.x() + rect.width()) > size.width() || (rect.y() + rect.height()) > size.height())
    memset(data, 0, result->data()->length());

[Andreas Kling]

Created attachment 60269 [details]
Proposed patch

[WebKit Commit Bot]

Comment on attachment 60269 [details]
Proposed patch

Rejecting patch 60269 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Last 500 characters of output:
ing build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Skipped list contained 'compositing/iframes/composited-iframe.html', but no file of that name could be found
Testing 19271 test cases.
canvas/philip/tests/2d.imageData.get.source.outside.html -> failed

Exiting early after 1 failures. 387 tests run.
17.69s total testing time

386 test cases (99%) succeeded
1 test case (<1%) had incorrect layout

Full output: http://webkit-commit-queue.appspot.com/results/3398077

[Andreas Kling]

(In reply to comment #2)
> canvas/philip/tests/2d.imageData.get.source.outside.html -> failed

Not sure what to do about this, the test passes when I run it on a Mac here.

[Andreas Kling]

Committed r63202: <http://trac.webkit.org/changeset/63202>

[WebKit Review Bot]

http://trac.webkit.org/changeset/63202 might have broken Leopard Intel Release (Tests)
The following changes are on the blame list:
http://trac.webkit.org/changeset/63202
http://trac.webkit.org/changeset/63203

[Andreas Kling]

Reopening since it fails reproducibly on the bot.

[Andreas Kling]

Put it back on the mac skiplist: <http://trac.webkit.org/changeset/63209>

[Adam Barth]

Comment on attachment 60269 [details]
Proposed patch

Looks like we'll need a new patch here.

[Ahmad Saleem]

It is on WPT now and Safari / WebKit passes this: https://wpt.fyi/results/html/canvas?label=master&label=experimental&aligned&q=2d.imagedata.get.source.outside.html

Marking this as 'Configuration Changed'.