Bug 41478 - canvas/philip/tests/2d.imageData.get.source.outside.html fails on the Mac bot
Summary: canvas/philip/tests/2d.imageData.get.source.outside.html fails on the Mac bot
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh All
: P2 Normal
Assignee: Nobody
URL:
Keywords: HTML5, PlatformOnly
Depends on:
Blocks:
 
Reported: 2010-07-01 12:10 PDT by Andreas Kling
Modified: 2010-08-10 22:38 PDT (History)
6 users (show)

See Also:


Attachments
Proposed patch (2.42 KB, patch)
2010-07-01 12:13 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-07-01 12:10:49 PDT
This test already works, thanks to the following code in getImageData:

if (rect.x() < 0 || rect.y() < 0 || (rect.x() + rect.width()) > size.width() || (rect.y() + rect.height()) > size.height())
    memset(data, 0, result->data()->length());
Comment 1 Andreas Kling 2010-07-01 12:13:26 PDT
Created attachment 60269 [details]
Proposed patch
Comment 2 WebKit Commit Bot 2010-07-01 19:37:54 PDT
Comment on attachment 60269 [details]
Proposed patch

Rejecting patch 60269 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Last 500 characters of output:
ing build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Skipped list contained 'compositing/iframes/composited-iframe.html', but no file of that name could be found
Testing 19271 test cases.
canvas/philip/tests/2d.imageData.get.source.outside.html -> failed

Exiting early after 1 failures. 387 tests run.
17.69s total testing time

386 test cases (99%) succeeded
1 test case (<1%) had incorrect layout

Full output: http://webkit-commit-queue.appspot.com/results/3398077
Comment 3 Andreas Kling 2010-07-12 09:07:56 PDT
(In reply to comment #2)
> canvas/philip/tests/2d.imageData.get.source.outside.html -> failed

Not sure what to do about this, the test passes when I run it on a Mac here.
Comment 4 Andreas Kling 2010-07-13 07:25:12 PDT
Committed r63202: <http://trac.webkit.org/changeset/63202>
Comment 5 WebKit Review Bot 2010-07-13 08:20:57 PDT
http://trac.webkit.org/changeset/63202 might have broken Leopard Intel Release (Tests)
The following changes are on the blame list:
http://trac.webkit.org/changeset/63202
http://trac.webkit.org/changeset/63203
Comment 6 Andreas Kling 2010-07-13 08:30:34 PDT
Reopening since it fails reproducibly on the bot.
Comment 7 Andreas Kling 2010-07-13 08:32:51 PDT
Put it back on the mac skiplist: <http://trac.webkit.org/changeset/63209>
Comment 8 Adam Barth 2010-08-10 22:38:23 PDT
Comment on attachment 60269 [details]
Proposed patch

Looks like we'll need a new patch here.