Bug 4147 - Array.toString() and toLocaleString() improvements from KDE KJS
Summary: Array.toString() and toLocaleString() improvements from KDE KJS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: Other Linux
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks: 94688
  Show dependency tree / graph
 
Reported: 2005-07-26 15:12 PDT by Harri Porten
Modified: 2012-08-22 03:51 PDT (History)
0 users

See Also:

Attachments
Patch (2.13 KB, patch)
2005-07-27 16:52 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
fast/js/toString-overrides.html (3.05 KB, text/html)
2005-07-27 16:53 PDT, Geoffrey Garen 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Harri Porten 2005-07-26 15:12:47 PDT 
I have problems reaching KDE's websvn server so I'm posting patches by linking  
to the CVS mail archive:  
  
The tests I added in  
   
 http://lists.kde.org/?l=kde-commits&m=112241237705027&w=2  
  
demonstrate a set of problems that the current JSC (and also KDE's previous)  
implementation of Array.toString() and toLocaleString() has. The patch I added  
  
 http://lists.kde.org/?l=kde-commits&m=112241230116304&w=2 
 
tries to implement the behavior as I understand it. Maybe there's more to it. 
Could well be that the code should be factored out. 
 
Would appreciate if possible changes to the patch would be fed back to KDE. 
Thanks.
Comment 1 Geoffrey Garen 2005-07-27 16:52:41 PDT 
Created attachment 3123 [details]
Patch

Uploaded JSC patch.
Comment 2 Geoffrey Garen 2005-07-27 16:53:28 PDT 
Created attachment 3124 [details]
fast/js/toString-overrides.html

Uploaded layout test.