Bug 41463 - [GTK] Stop using GdkRegion in 3.x mode
Summary: [GTK] Stop using GdkRegion in 3.x mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-01 07:17 PDT by Xan Lopez
Modified: 2010-07-01 16:58 PDT (History)
1 user (show)

See Also:


Attachments
gdkregion.diff (12.33 KB, patch)
2010-07-01 07:19 PDT, Xan Lopez
no flags Details | Formatted Diff | Diff
gdkregion.diff (12.67 KB, patch)
2010-07-01 13:53 PDT, Xan Lopez
no flags Details | Formatted Diff | Diff
gdkregion.diff (12.72 KB, patch)
2010-07-01 14:23 PDT, Xan Lopez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2010-07-01 07:17:17 PDT
GdkRegion was completely removed in GTK+ 3.x, and GdkRectangle just made an alias for a cairo rectangle. This patch moves us unconditionally to cairo_region_t when possible, and when that's not possible (because there's interaction with GTK+), creates a branch using the cairo API.
Comment 1 Xan Lopez 2010-07-01 07:19:36 PDT
Created attachment 60245 [details]
gdkregion.diff
Comment 2 WebKit Review Bot 2010-07-01 07:20:32 PDT
Attachment 60245 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/platform/graphics/IntRect.h:54:  cairo_rectangle_int_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/RenderThemeGtk.h:40:  cairo_rectangle_int_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/graphics/gtk/FontGtk.cpp:187:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/graphics/gtk/FontGtk.cpp:187:  n_rects is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/graphics/gtk/FontGtk.cpp:188:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/graphics/gtk/FontGtk.cpp:189:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/graphics/gtk/FontGtk.cpp:191:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/graphics/gtk/FontGtk.cpp:221:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 8 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Xan Lopez 2010-07-01 13:53:11 PDT
Created attachment 60282 [details]
gdkregion.diff

This version does not unify some code paths, so that we don't have to depend on a pretty new cairo version.
Comment 4 WebKit Review Bot 2010-07-01 13:55:36 PDT
Attachment 60282 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/platform/graphics/IntRect.h:54:  cairo_rectangle_int_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/RenderThemeGtk.h:40:  cairo_rectangle_int_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/graphics/gtk/FontGtk.cpp:188:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/graphics/gtk/FontGtk.cpp:188:  n_rects is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/graphics/gtk/FontGtk.cpp:189:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/graphics/gtk/FontGtk.cpp:190:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/graphics/gtk/FontGtk.cpp:192:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/graphics/gtk/FontGtk.cpp:226:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 8 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Xan Lopez 2010-07-01 14:23:38 PDT
Created attachment 60286 [details]
gdkregion.diff

Third time is the charm.

I'm not friends with EWS anymore.
Comment 6 WebKit Review Bot 2010-07-01 14:25:41 PDT
Attachment 60286 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/platform/graphics/IntRect.h:54:  cairo_rectangle_int_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/RenderThemeGtk.h:40:  cairo_rectangle_int_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/graphics/gtk/FontGtk.cpp:185:  cairo_region_shrink is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 3 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Gustavo Noronha (kov) 2010-07-01 16:33:45 PDT
Comment on attachment 60286 [details]
gdkregion.diff

WebCore/platform/graphics/gtk/FontGtk.cpp:188
 +      /* clear region */
Fix this to be a real WebKit comment ;D

You are on your way to destruction, make your time.
Comment 8 Xan Lopez 2010-07-01 16:58:39 PDT
Comment on attachment 60286 [details]
gdkregion.diff

Landed in r62329.
Comment 9 Xan Lopez 2010-07-01 16:58:50 PDT
Kabloom.