Bug 41459 - Improve the main lexer switch by mapping input characters to their type
Summary: Improve the main lexer switch by mapping input characters to their type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-01 05:26 PDT by Zoltan Herczeg
Modified: 2010-07-01 23:30 PDT (History)
1 user (show)

See Also:


Attachments
patch (19.88 KB, patch)
2010-07-01 05:29 PDT, Zoltan Herczeg
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Herczeg 2010-07-01 05:26:33 PDT
The array can be used for other purposes as well.

SunSpider: no cahnge

Parse-only tests:

TEST                           COMPARISON            FROM                 TO             DETAILS

=============================================================================

** TOTAL **:                   1.025x as fast    33.1ms +/- 1.9%   32.3ms +/- 1.1%     significant

=============================================================================

  jquery:                      ??                 5.0ms +/- 0.0%    5.1ms +/- 4.4%     not conclusive: might be *1.020x as slow*
    1.3.2:                     ??                 5.0ms +/- 0.0%    5.1ms +/- 4.4%     not conclusive: might be *1.020x as slow*

  mootools:                    -                  5.3ms +/- 6.5%    5.1ms +/- 4.4%
    1.2.2-core-nc:             -                  5.3ms +/- 6.5%    5.1ms +/- 4.4%

  prototype:                   -                  6.3ms +/- 5.5%    6.1ms +/- 3.7%
    1.6.0.3:                   -                  6.3ms +/- 5.5%    6.1ms +/- 3.7%

  concat:                      1.031x as fast    16.5ms +/- 2.3%   16.0ms +/- 0.0%     significant
    jquery-mootools-prototype: 1.031x as fast    16.5ms +/- 2.3%   16.0ms +/- 0.0%     significant
Comment 1 Zoltan Herczeg 2010-07-01 05:29:26 PDT
Created attachment 60225 [details]
patch
Comment 2 Oliver Hunt 2010-07-01 12:09:11 PDT
Comment on attachment 60225 [details]
patch

r=me
Comment 3 Zoltan Herczeg 2010-07-01 23:30:48 PDT
Landed in http://trac.webkit.org/changeset/62366
Closing bug.