Bug 41457 - [Qt] Dragging within webkit with a drag created via Javascript ends up misinterpreting the data
Summary: [Qt] Dragging within webkit with a drag created via Javascript ends up misint...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: QtWebKit Unassigned
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-07-01 05:15 PDT by andy.shaw
Modified: 2010-07-12 08:18 PDT (History)
2 users (show)

See Also:

Attachments
Example HTML reproducing the problem (2.50 KB, text/html)
2010-07-01 05:15 PDT, andy.shaw 		no flags Details
Propsoed patch (1.26 KB, patch)
2010-07-01 05:16 PDT, andy.shaw 		no flags Details | Formatted Diff | Diff
Proposed patch (trunk) (1.35 KB, patch)
2010-07-01 07:43 PDT, Andreas Kling 		kling: review-
Details | Formatted Diff | Diff
Proposed patch v2 (5.84 KB, patch)
2010-07-12 08:01 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description andy.shaw 2010-07-01 05:15:22 PDT 
Created attachment 60222 [details]
Example HTML reproducing the problem

Dragging within webkit with a drag created via Javascript ends up misinterpreting the data, in the example attached if you drag from the drag area to the drop area then you will see that the data looks like it has been converted incorrectly.
Comment 1 andy.shaw 2010-07-01 05:16:05 PDT 
Created attachment 60223 [details]
Propsoed patch
Comment 2 Andreas Kling 2010-07-01 07:05:39 PDT 
Confirmed on ToT + current 4.7. We only treat "text/plain" as UTF-16 text right now.
Comment 3 Andreas Kling 2010-07-01 07:43:09 PDT 
Created attachment 60247 [details]
Proposed patch (trunk)
Comment 4 Andreas Kling 2010-07-07 07:39:11 PDT 
Comment on attachment 60247 [details]
Proposed patch (trunk)

r- after discussion with Simon. ClipboardQt needs more robustness in both getData() and setData() if we're to support arbitrary mimetypes. New patch coming in a bit.
Comment 5 Andreas Kling 2010-07-12 08:01:02 PDT 
Created attachment 61231 [details]
Proposed patch v2
Comment 6 WebKit Commit Bot 2010-07-12 08:18:11 PDT 
Comment on attachment 61231 [details]
Proposed patch v2

Clearing flags on attachment: 61231

Committed r63089: <http://trac.webkit.org/changeset/63089>
Comment 7 WebKit Commit Bot 2010-07-12 08:18:16 PDT 
All reviewed patches have been landed.  Closing bug.