Bug 41456 - Buildfix for !ENABLE(FILTERS)
Summary: Buildfix for !ENABLE(FILTERS)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-01 04:53 PDT by Patrick R. Gansterer
Modified: 2010-07-04 11:06 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.14 KB, patch)
2010-07-01 04:54 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch (1.10 KB, patch)
2010-07-01 05:42 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-07-01 04:53:44 PDT
see patch
Comment 1 Patrick R. Gansterer 2010-07-01 04:54:28 PDT
Created attachment 60221 [details]
Patch
Comment 2 Dirk Schulze 2010-07-01 05:06:06 PDT
Comment on attachment 60221 [details]
Patch

Thank you very much and sorry for forgetting this var every time. :-(
Comment 3 WebKit Commit Bot 2010-07-01 05:28:51 PDT
Comment on attachment 60221 [details]
Patch

Clearing flags on attachment: 60221

Committed r62252: <http://trac.webkit.org/changeset/62252>
Comment 4 WebKit Commit Bot 2010-07-01 05:28:55 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Patrick R. Gansterer 2010-07-01 05:42:13 PDT
Soory, missed the second use. :-(
Comment 6 Patrick R. Gansterer 2010-07-01 05:42:45 PDT
Created attachment 60228 [details]
Patch
Comment 7 Nikolas Zimmermann 2010-07-01 05:56:00 PDT
Comment on attachment 60228 [details]
Patch

r=me.
Comment 8 WebKit Commit Bot 2010-07-01 06:14:34 PDT
Comment on attachment 60228 [details]
Patch

Rejecting patch 60228 from commit-queue.

Unexpected failure when processing patch!  Please file a bug against webkit-patch.
Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 60228, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1
Logging in as eseidel@chromium.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=60228&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=41456&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Processing patch 60228 from bug 41456.
ERROR: /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 9 Patrick R. Gansterer 2010-07-04 10:17:41 PDT
Comment on attachment 60228 [details]
Patch

(In reply to comment #8)
> (From update of attachment 60228 [details])
> Rejecting patch 60228 from commit-queue.
Why?
Comment 10 WebKit Commit Bot 2010-07-04 10:45:08 PDT
Comment on attachment 60228 [details]
Patch

Clearing flags on attachment: 60228

Committed r62467: <http://trac.webkit.org/changeset/62467>
Comment 11 WebKit Commit Bot 2010-07-04 10:45:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Patrick R. Gansterer 2010-07-04 11:06:19 PDT
(In reply to comment #10)
> (From update of attachment 60228 [details])
> Clearing flags on attachment: 60228
> 
> Committed r62467: <http://trac.webkit.org/changeset/62467>
I think the SVN log message is wrong. Bug in the queue?