Bug 41449 - [Qt] Autotest got missed in the handover of the QML WebView element
Summary: [Qt] Autotest got missed in the handover of the QML WebView element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Caio Marcelo de Oliveira Filho
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-07-01 02:01 PDT by Alan Alpert
Modified: 2011-05-04 13:00 PDT (History)
4 users (show)

See Also:

Attachments
patch (45.69 KB, patch)
2011-04-15 17:02 PDT, Caio Marcelo de Oliveira Filho 		no flags Details | Formatted Diff | Diff
some code cleanup (1.69 KB, patch)
2011-04-19 12:53 PDT, Gopal Raghavan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Alpert 2010-07-01 02:01:23 PDT 
The autotests for this element are still in the Qt source tree (tests/auto/declarative) when they should be moved to be with the webkit tests (and then maintained with the WebView element).
Comment 1 Caio Marcelo de Oliveira Filho 2011-04-15 17:02:54 PDT 
Created attachment 89883 [details]
patch
Comment 2 Andreas Kling 2011-04-16 21:16:04 PDT 
Comment on attachment 89883 [details]
patch

rs=me
Comment 3 WebKit Commit Bot 2011-04-16 23:29:41 PDT 
Comment on attachment 89883 [details]
patch

Clearing flags on attachment: 89883

Committed r84100: <http://trac.webkit.org/changeset/84100>
Comment 4 WebKit Commit Bot 2011-04-16 23:29:46 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Commit Bot 2011-04-17 00:43:01 PDT 
The commit-queue encountered the following flaky tests while processing attachment 89883 [details]:

java/lc3/JSObject/ToObject-001.html bug 53091 (author: ap@webkit.org)
http/tests/xmlhttprequest/cross-origin-authorization.html bug 52398 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.
Comment 6 Gopal Raghavan 2011-04-19 12:53:25 PDT 
Created attachment 90240 [details]
some code cleanup
Comment 7 Caio Marcelo de Oliveira Filho 2011-04-19 12:55:54 PDT 
Gopal. I let that code there because the idea is to change the test so we do not depend on the private of QtDeclarative. See the QSKIP statement.
Comment 8 Eric Seidel (no email) 2011-04-20 13:37:16 PDT 
Comment on attachment 90240 [details]
some code cleanup

Cleared review? from attachment 90240 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).