Bug 41438 - Abstract 'a'-'z' checks into a function
Summary: Abstract 'a'-'z' checks into a function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-30 16:54 PDT by Adam Barth
Modified: 2010-07-01 02:42 PDT (History)
3 users (show)

See Also:

Attachments
Patch (12.03 KB, patch)
2010-06-30 17:11 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (11.14 KB, patch)
2010-06-30 23:32 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-06-30 16:54:33 PDT 
Abstract 'a'-'z' checks into a function
Comment 1 Adam Barth 2010-06-30 17:11:14 PDT 
Created attachment 60171 [details]
Patch
Comment 2 Adam Barth 2010-06-30 17:12:11 PDT 
@Sam: I think you said there were some functions in a header somewhere that does this.  I couldn't find it.  Do you know where it is off-hand?
Comment 3 Eric Seidel (no email) 2010-06-30 17:15:12 PDT 
wtf/ASCIICType.h
Comment 4 Eric Seidel (no email) 2010-06-30 17:21:39 PDT 
Comment on attachment 60171 [details]
Patch

We should use the wtf functions.
Comment 5 Darin Adler 2010-06-30 18:48:45 PDT 
Comment on attachment 60171 [details]
Patch

ASCIICType.h has all of these. You'd want to use isASCIIUpper and isASCIILower and toASCIILower.
Comment 6 Adam Barth 2010-06-30 23:32:33 PDT 
Created attachment 60204 [details]
Patch
Comment 7 Adam Barth 2010-06-30 23:33:59 PDT 
> ASCIICType.h has all of these. You'd want to use isASCIIUpper and isASCIILower and toASCIILower.

I didn't do toASCIILower because it's more complicated than what we're using (because we only call ours on ASCII upper chars), but I did the rest.
Comment 8 WebKit Commit Bot 2010-07-01 02:42:15 PDT 
Comment on attachment 60204 [details]
Patch

Clearing flags on attachment: 60204

Committed r62242: <http://trac.webkit.org/changeset/62242>
Comment 9 WebKit Commit Bot 2010-07-01 02:42:19 PDT 
All reviewed patches have been landed.  Closing bug.