Bug 41437 - Add interface for network platform to pass up timing information
Summary: Add interface for network platform to pass up timing information
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Gentilcore
URL:
Keywords:
Depends on:
Blocks: 30685
  Show dependency treegraph
 
Reported: 2010-06-30 16:40 PDT by Tony Gentilcore
Modified: 2010-07-01 19:23 PDT (History)
3 users (show)

See Also:


Attachments
Patch (14.99 KB, patch)
2010-06-30 19:03 PDT, Tony Gentilcore
no flags Details | Formatted Diff | Diff
Patch for landing (14.99 KB, patch)
2010-06-30 21:51 PDT, Tony Gentilcore
no flags Details | Formatted Diff | Diff
Patch for landing (14.96 KB, patch)
2010-07-01 11:53 PDT, Tony Gentilcore
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2010-06-30 16:40:32 PDT
Add interface for network platform to pass up timing information
Comment 1 Tony Gentilcore 2010-06-30 19:03:57 PDT
Created attachment 60183 [details]
Patch
Comment 2 Adam Barth 2010-06-30 20:28:14 PDT
Comment on attachment 60183 [details]
Patch

Why a RefPtr and not an OwnPtr?  I didn't see any sharing, but I might have missed it.

WebCore/platform/network/ResourceLoadTiming.h:44
 +          RefPtr<ResourceLoadTiming> timing(create());
we usually use the = form
Comment 3 Tony Gentilcore 2010-06-30 20:40:07 PDT
(In reply to comment #2)
> (From update of attachment 60183 [details])
> Why a RefPtr and not an OwnPtr?  I didn't see any sharing, but I might have missed it.

ResourceResponseBase is copyable, but OwnPtr is not. So it can't have OwnPtr members. This patch follows the pattern of FormData on ResourceRequestBase.

> 
> WebCore/platform/network/ResourceLoadTiming.h:44
>  +          RefPtr<ResourceLoadTiming> timing(create());
> we usually use the = form

OK
Comment 4 Adam Barth 2010-06-30 20:41:42 PDT
Comment on attachment 60183 [details]
Patch

Ah, thanks.  I'm not 100% clear on the motivation for this change, but the code itself looks fine.
Comment 5 Tony Gentilcore 2010-06-30 20:54:51 PDT
(In reply to comment #4)
> (From update of attachment 60183 [details])
> Ah, thanks.  I'm not 100% clear on the motivation for this change, but the code itself looks fine.

I'm implementing: http://dev.w3.org/2006/webapi/WebTiming/

Some of the timings can be measures solely in WebKit. Those are in https://bugs.webkit.org/show_bug.cgi?id=41332

The rest of the timings have to be passed up from the network platform. That is what this is for.
Comment 6 Tony Gentilcore 2010-06-30 21:51:26 PDT
Created attachment 60192 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2010-07-01 01:33:05 PDT
Comment on attachment 60192 [details]
Patch for landing

Rejecting patch 60192 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1
Last 500 characters of output:
hing file WebCore/WebCore.vcproj/WebCore.vcproj
patching file WebCore/WebCore.xcodeproj/project.pbxproj
Hunk #2 succeeded at 7972 (offset 2 lines).
Hunk #3 succeeded at 12041 (offset 4 lines).
Hunk #4 FAILED at 19668.
1 out of 4 hunks FAILED -- saving rejects to file WebCore/WebCore.xcodeproj/project.pbxproj.rej
patching file WebCore/platform/network/ResourceLoadTiming.h
patching file WebCore/platform/network/ResourceResponseBase.cpp
patching file WebCore/platform/network/ResourceResponseBase.h

Full output: http://webkit-commit-queue.appspot.com/results/3373083
Comment 8 Tony Gentilcore 2010-07-01 11:53:57 PDT
Created attachment 60267 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2010-07-01 19:22:55 PDT
Comment on attachment 60267 [details]
Patch for landing

Clearing flags on attachment: 60267

Committed r62348: <http://trac.webkit.org/changeset/62348>
Comment 10 WebKit Commit Bot 2010-07-01 19:23:00 PDT
All reviewed patches have been landed.  Closing bug.