Bug 41424 - Stop linking against opengl32.lib in Windows Chromium port
Summary: Stop linking against opengl32.lib in Windows Chromium port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on: 41430
Blocks:
  Show dependency tree / graph
 
Reported: 2010-06-30 12:03 PDT by Kenneth Russell
Modified: 2010-07-01 12:45 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.68 KB, patch)
2010-06-30 12:13 PDT, Kenneth Russell 		kbr: commit-queue-
Details | Formatted Diff | Diff
Revised patch (4.69 KB, patch)
2010-06-30 12:23 PDT, Kenneth Russell 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-06-30 12:03:01 PDT 
The Windows Chromium port links against opengl32.lib for the legacy in-process WebGL implementation (which may still be useful as a basis for other ports, which is one of the reasons it is still being left in place). This dependency is impacting browser startup time. The copy of GLEW in Chromium has been updated to dynamically look up all of the core WGL entry points; the code in WebKit needs to be updated to use the new entry points and stop adding opengl32.lib to the link line.

See http://crbug.com/45586 .
Comment 1 Kenneth Russell 2010-06-30 12:13:51 PDT 
Created attachment 60141 [details]
Patch
Comment 2 WebKit Review Bot 2010-06-30 12:14:55 PDT 
Attachment 60141 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit/chromium/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Kenneth Russell 2010-06-30 12:23:34 PDT 
Created attachment 60142 [details]
Revised patch

Revised patch fixing tab in ChangeLog
Comment 4 Dimitri Glazkov (Google) 2010-06-30 14:16:48 PDT 
Comment on attachment 60142 [details]
Revised patch

Please roll DEPS in WebKit/chromium to pick up downstream changes before landing this.
Comment 5 Kenneth Russell 2010-07-01 12:44:58 PDT 
Comment on attachment 60142 [details]
Revised patch

Clearing flags on attachment: 60142

Committed r62288: <http://trac.webkit.org/changeset/62288>
Comment 6 Kenneth Russell 2010-07-01 12:45:03 PDT 
All reviewed patches have been landed.  Closing bug.