Bug 41424 – Stop linking against opengl32.lib in Windows Chromium port

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Kenneth Russell]

The Windows Chromium port links against opengl32.lib for the legacy in-process WebGL implementation (which may still be useful as a basis for other ports, which is one of the reasons it is still being left in place). This dependency is impacting browser startup time. The copy of GLEW in Chromium has been updated to dynamically look up all of the core WGL entry points; the code in WebKit needs to be updated to use the new entry points and stop adding opengl32.lib to the link line.

See http://crbug.com/45586 .

[Kenneth Russell]

Created attachment 60141 [details]
Patch

[WebKit Review Bot]

Attachment 60141 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit/chromium/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kenneth Russell]

Created attachment 60142 [details]
Revised patch

Revised patch fixing tab in ChangeLog

[Dimitri Glazkov (Google)]

Comment on attachment 60142 [details]
Revised patch

Please roll DEPS in WebKit/chromium to pick up downstream changes before landing this.

[Kenneth Russell]

Comment on attachment 60142 [details]
Revised patch

Clearing flags on attachment: 60142

Committed r62288: <http://trac.webkit.org/changeset/62288>

[Kenneth Russell]

All reviewed patches have been landed.  Closing bug.