Add WebProcessProxy::send
Created attachment 60127 [details] Patch
Comment on attachment 60127 [details] Patch > + CoreIPC::Connection* connection() const > + { > + ASSERT(m_connection); > + > + return m_connection.get(); > + } I don't see any callers of this new function. > +template<typename E, typename T> > +bool WebProcessProxy::send(E messageID, uint64_t destinationID, const T& arguments) > +{ > + std::auto_ptr<CoreIPC::ArgumentEncoder> argumentEncoder(new CoreIPC::ArgumentEncoder(destinationID)); > + argumentEncoder->encode(arguments); > + > + return sendMessage(CoreIPC::MessageID(messageID), argumentEncoder); > +} Why are you using auto_ptr instead of OwnPtr? r=me
(In reply to comment #2) > (From update of attachment 60127 [details]) > > + CoreIPC::Connection* connection() const > > + { > > + ASSERT(m_connection); > > + > > + return m_connection.get(); > > + } > > I don't see any callers of this new function. It's not a new function, I simply added an assert to connection(). > > Why are you using auto_ptr instead of OwnPtr? We just haven't changed CoreIPC over to using wtf types everywhere. > r=me Thanks!
Fixed in http://trac.webkit.org/projects/webkit/changeset/62190