CLOSED FIXED 41412
[Qt] Canvas arcTo() should draw straight line to p1 if p0, p1 and p2 are collinear 
https://bugs.webkit.org/show_bug.cgi?id=41412
Summary [Qt] Canvas arcTo() should draw straight line to p1 if p0, p1 and p2 are coll...
Andreas Kling
Reported Wednesday, June 30, 2010 5:29:28 PM UTC
If p0, p1 and p2 are all points on a single straight line, arcTo() should draw a straight line from p0 to p1. Spec link: http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-arcto This fixes two in-tree tests: * canvas/philip/tests/2d.path.arcTo.collinear.2.html * canvas/philip/tests/2d.path.arcTo.collinear.3.html
Attachments
Proposed patch (3.28 KB, patch)
2010-06-30 09:32 PDT, Andreas Kling 		vestbo: review-
vestbo: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 Wednesday, June 30, 2010 5:32:25 PM UTC
Created attachment 60126 [details] Proposed patch
WebKit Review Bot
Comment 2 Wednesday, June 30, 2010 5:34:11 PM UTC
Attachment 60126 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/platform/graphics/qt/PathQt.cpp:209: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 Thursday, July 1, 2010 7:40:00 PM UTC
Relevant part of HTML5 spec: "... if the points (x0, y0), (x1, y1), and (x2, y2) all lie on a single straight line, then the method must add the point (x1, y1) to the subpath, and connect that point to the previous point (x0, y0) by a straight line." Note that p0 (or (x0, x0)) here refers to the last point in the current subpath.
Tor Arne Vestbø
Comment 4 Thursday, July 1, 2010 8:05:56 PM UTC
Comment on attachment 60126 [details] Proposed patch LGTM
Tor Arne Vestbø
Comment 5 Thursday, July 1, 2010 8:21:39 PM UTC
Comment on attachment 60126 [details] Proposed patch r- for now until we can verify the collinar()
Tor Arne Vestbø
Comment 6 Friday, July 2, 2010 3:26:42 PM UTC
Fix for this is coming, preparing patch
Tor Arne Vestbø
Comment 7 Friday, July 2, 2010 4:24:29 PM UTC
Landed in http://trac.webkit.org/changeset/62383
Simon Hausmann
Comment 8 Friday, July 2, 2010 4:34:14 PM UTC
<cherry-pick-for-backport: r62383>
Simon Hausmann
Comment 9 Friday, July 2, 2010 4:38:51 PM UTC
Revision r62383 cherry-picked into qtwebkit-2.0 with commit 13b5b7048431a554e48c4b28235cf206c6a08bf5
Note You need to log in before you can comment on or make changes to this bug.