Bug 41409 - Safari pegs CPU and drops frames on http://neography.com/experiment/circles/solarsystem/ (CSS animations)
Summary: Safari pegs CPU and drops frames on http://neography.com/experiment/circles/s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Simon Fraser (smfr)
URL: http://neography.com/experiment/circl...
Keywords: InRadar, PlatformOnly
Depends on:
Blocks:
 
Reported: 2010-06-30 07:32 PDT by Adam Roben (:aroben)
Modified: 2010-07-16 13:32 PDT (History)
2 users (show)

See Also:


Attachments
Patch (21.65 KB, patch)
2010-07-15 16:46 PDT, Simon Fraser (smfr)
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-06-30 07:32:39 PDT
To reproduce:

1. Go to http://neography.com/experiment/circles/solarsystem/

The animation is quite choppy. If you look at Task Manager you'll see that Safari is pegging a CPU.
Comment 1 Adam Roben (:aroben) 2010-06-30 07:33:15 PDT
<rdar://problem/8146502>
Comment 2 Adam Roben (:aroben) 2010-06-30 07:35:24 PDT
On Mac, the performance is almost as bad if I turn off accelerated compositing.

It looks like this page isn't getting kicked into accelerated mode on Windows.
Comment 3 Simon Fraser (smfr) 2010-06-30 11:31:46 PDT
One issue here is that in AnimationBase, m_fallbackAnimating is always set to true when we don't use hardware animation, resulting in isAnimationRunning() returning false, which causes us to not use hardware.
Comment 4 Simon Fraser (smfr) 2010-06-30 11:42:22 PDT
Ah, I think the real issue is that on Windows, we still think we have accelerated opacity and transform animations.
Comment 5 Simon Fraser (smfr) 2010-07-15 16:46:55 PDT
Created attachment 61745 [details]
Patch
Comment 6 Simon Fraser (smfr) 2010-07-16 13:32:12 PDT
http://trac.webkit.org/changeset/63576