Bug 41407 - [Qt] Make "disallow multiple calls to SetWindow" on windowed plugins a quirk
Summary: [Qt] Make "disallow multiple calls to SetWindow" on windowed plugins a quirk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
: 41037 (view as bug list)
Depends on:
Blocks: 40879
  Show dependency treegraph
 
Reported: 2010-06-30 06:43 PDT by Andreas Kling
Modified: 2010-07-18 14:16 PDT (History)
2 users (show)

See Also:


Attachments
Proposed patch (4.66 KB, patch)
2010-06-30 06:53 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-06-30 06:43:30 PDT
Right now, we disallow more than one call to SetWindow on plugins since Flash used to crash if not running on top of Gtk+.

Gtk+ unnecessarily copied this logic from PluginViewQt.cpp
Comment 1 Andreas Kling 2010-06-30 06:53:53 PDT
Created attachment 60116 [details]
Proposed patch
Comment 2 Kenneth Rohde Christiansen 2010-06-30 07:59:37 PDT
Comment on attachment 60116 [details]
Proposed patch

PluginViewQt should really have Linux in its name :-)
Comment 3 WebKit Commit Bot 2010-06-30 08:16:36 PDT
Comment on attachment 60116 [details]
Proposed patch

Clearing flags on attachment: 60116

Committed r62185: <http://trac.webkit.org/changeset/62185>
Comment 4 WebKit Commit Bot 2010-06-30 08:16:40 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Andreas Kling 2010-07-18 14:16:01 PDT
*** Bug 41037 has been marked as a duplicate of this bug. ***