Bug 41406 - [Qt, Gtk, Symbian] Mind the semantics of NPRect for windowed plugin clip rects
Summary: [Qt, Gtk, Symbian] Mind the semantics of NPRect for windowed plugin clip rects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-06-30 05:44 PDT by Andreas Kling
Modified: 2010-06-30 07:20 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (3.72 KB, patch)
2010-06-30 05:49 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-06-30 05:44:06 PDT 
There is code like this in PluginView{Qt,Gtk,Symbian}.cpp:

m_npWindow.clipRect.left = m_clipRect.x();
m_npWindow.clipRect.top = m_clipRect.y();
m_npWindow.clipRect.right = m_clipRect.width();
m_npWindow.clipRect.bottom = m_clipRect.height();

(right vs width, bottom vs height)
This causes incorrect clipping of windowed plugins.
Comment 1 Andreas Kling 2010-06-30 05:49:06 PDT 
Created attachment 60114 [details]
Proposed patch
Comment 2 Simon Hausmann 2010-06-30 05:59:39 PDT 
Can you explain on which website this breaks and/or what your test-case was?
Comment 3 Andreas Kling 2010-06-30 06:07:27 PDT 
(In reply to comment #2)
> Can you explain on which website this breaks and/or what your test-case was?

I have no test-case, I'm actually working on bug 40879 but wanted to do this in a separate patch since it touches other platforms' files.
Comment 4 WebKit Commit Bot 2010-06-30 07:20:17 PDT 
Comment on attachment 60114 [details]
Proposed patch

Clearing flags on attachment: 60114

Committed r62184: <http://trac.webkit.org/changeset/62184>
Comment 5 WebKit Commit Bot 2010-06-30 07:20:22 PDT 
All reviewed patches have been landed.  Closing bug.