RESOLVED FIXED 41397
HTMLTokenizer should use fewer macros 
https://bugs.webkit.org/show_bug.cgi?id=41397
Summary HTMLTokenizer should use fewer macros
Adam Barth
Reported 2010-06-30 02:25:20 PDT
HTMLTokenizer should use fewer macros
Attachments
Patch (55.38 KB, patch)
2010-06-30 02:26 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (55.56 KB, patch)
2010-06-30 02:44 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-06-30 02:26:15 PDT
Created attachment 60102 [details] Patch
Eric Seidel (no email)
Comment 2 2010-06-30 02:38:49 PDT
Comment on attachment 60102 [details] Patch I like this. It's a bit subtle that we now always have to call "return emit*" and never just "emit*". The macros were slightly nice for making sure folks didn't hit that error. You might try searching for " emit" just to make sure we didn't miss one. "bufferCurrentToken" makes little sense. :) It's an emit-helper, it doesn't do any buffering. bufferCharacter on the other hand is a great name! bufferEndOfFile also makes no sense. it's just called by emitEndOfFile and can just be inlined.
Adam Barth
Comment 3 2010-06-30 02:44:51 PDT
Created attachment 60103 [details] Patch for landing
WebKit Commit Bot
Comment 4 2010-06-30 03:27:15 PDT
Comment on attachment 60103 [details] Patch for landing Clearing flags on attachment: 60103 Committed r62175: <http://trac.webkit.org/changeset/62175>
WebKit Commit Bot
Comment 5 2010-06-30 03:27:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.