Bug 41380 – linkProgram should fail when vertex/fragment shaders are not both present

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Zhenyao Mo]

In GL, when a shader is not present, the program will link against fixed functionality processing.  In GLES, it should fail.

[Zhenyao Mo]

Created attachment 60184 [details]
patch

test case is copied over from conformance tests (after fixing a bug in the test).

[Kenneth Russell]

Comment on attachment 60184 [details]
patch

Looks good.

[Dimitri Glazkov (Google)]

Comment on attachment 60184 [details]
patch

ok.

[WebKit Commit Bot]

Comment on attachment 60184 [details]
patch

Rejecting patch 60184 from commit-queue.

Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1
Last 500 characters of output:
l/canvas/WebGLShader.cpp
	M	WebCore/html/canvas/WebGLShader.h
A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output:

    The following files contain tab characters:

        trunk/LayoutTests/fast/canvas/webgl/program-test.html

    Please use spaces instead to indent.
    If you must commit a file with tabs, use svn propset to set the "allow-tabs" property.
 at /usr/local/git/libexec/git-core/git-svn line 570


Full output: http://webkit-commit-queue.appspot.com/results/3360165

[Zhenyao Mo]

Created attachment 60372 [details]
revised patch: remove tabs in the test file.

[WebKit Commit Bot]

Comment on attachment 60372 [details]
revised patch: remove tabs in the test file.

Rejecting patch 60372 from commit-queue.

Unexpected failure when processing patch!  Please file a bug against webkit-patch.
Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 60372, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1
Last 500 characters of output:
0372&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=41380&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Processing patch 60372 from bug 41380.
NOBODY (OOPS!) found in /Users/eseidel/Projects/CommitQueue/LayoutTests/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /Users/eseidel/Projects/CommitQueue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

[WebKit Commit Bot]

Comment on attachment 60372 [details]
revised patch: remove tabs in the test file.

Clearing flags on attachment: 60372

Committed r62396: <http://trac.webkit.org/changeset/62396>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/62396 might have broken Leopard Intel Debug (Tests)
The following changes are on the blame list:
http://trac.webkit.org/changeset/62395
http://trac.webkit.org/changeset/62396

[Zhenyao Mo]

Skip the program-test.html for now:

https://bugs.webkit.org/show_bug.cgi?id=41542

[Zhenyao Mo]

*** Bug 40746 has been marked as a duplicate of this bug. ***