Bug 41357 - REGRESSION(r62052): Causes crashes in JSLazyEventListener::initializeFunction (see bug 41352) (Requested by aroben on #webkit).
Summary: REGRESSION(r62052): Causes crashes in JSLazyEventListener::initializeFunction...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
: 41352 (view as bug list)
Depends on:
Blocks: 40484
  Show dependency treegraph
 
Reported: 2010-06-29 09:44 PDT by WebKit Review Bot
Modified: 2010-07-01 09:56 PDT (History)
5 users (show)

See Also:


Attachments
ROLLOUT of r62052 (19.88 KB, patch)
2010-06-29 09:44 PDT, WebKit Review Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2010-06-29 09:44:46 PDT
http://trac.webkit.org/changeset/62052 broke the build:
Causes crashes in JSLazyEventListener::initializeFunction (see bug 41352) (Requested by aroben on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2010-06-29 09:44:55 PDT
Created attachment 60029 [details]
ROLLOUT of r62052

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 David Levin 2010-06-29 09:57:47 PDT
This will likely break the chromium build and then http://trac.webkit.org/changeset/62073 will need to be rolled out too.
Comment 3 WebKit Commit Bot 2010-06-29 10:18:38 PDT
Comment on attachment 60029 [details]
ROLLOUT of r62052

Rejecting patch 60029 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1
Last 500 characters of output:
pp
Hunk #1 FAILED at 34.
Hunk #2 FAILED at 78.
Hunk #3 succeeded at 108 (offset 6 lines).
2 out of 3 hunks FAILED -- saving rejects to file WebCore/bindings/js/ScriptEventListener.cpp.rej
patching file WebCore/bindings/js/ScriptEventListener.h
patching file WebCore/bindings/v8/ScriptEventListener.cpp
patching file WebCore/bindings/v8/ScriptEventListener.h
patching file WebCore/html/HTMLBodyElement.cpp
patching file WebCore/html/HTMLFrameSetElement.cpp
patching file WebCore/svg/SVGSVGElement.cpp

Full output: http://webkit-commit-queue.appspot.com/results/3353188
Comment 4 WebKit Commit Bot 2010-06-29 10:55:24 PDT
Comment on attachment 60029 [details]
ROLLOUT of r62052

Rejecting patch 60029 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1
Last 500 characters of output:
pp
Hunk #1 FAILED at 34.
Hunk #2 FAILED at 78.
Hunk #3 succeeded at 108 (offset 6 lines).
2 out of 3 hunks FAILED -- saving rejects to file WebCore/bindings/js/ScriptEventListener.cpp.rej
patching file WebCore/bindings/js/ScriptEventListener.h
patching file WebCore/bindings/v8/ScriptEventListener.cpp
patching file WebCore/bindings/v8/ScriptEventListener.h
patching file WebCore/html/HTMLBodyElement.cpp
patching file WebCore/html/HTMLFrameSetElement.cpp
patching file WebCore/svg/SVGSVGElement.cpp

Full output: http://webkit-commit-queue.appspot.com/results/3323943
Comment 5 David Levin 2010-06-29 11:31:52 PDT
Comment on attachment 60029 [details]
ROLLOUT of r62052

Clearing flags on attachment: 60029

Committed r62139: <http://trac.webkit.org/changeset/62139>
Comment 6 David Levin 2010-06-29 11:32:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Adam Roben (:aroben) 2010-07-01 09:56:35 PDT
*** Bug 41352 has been marked as a duplicate of this bug. ***