RESOLVED FIXED 41347
Cleanup SVGRenderSupport 
https://bugs.webkit.org/show_bug.cgi?id=41347
Summary Cleanup SVGRenderSupport
Nikolas Zimmermann
Reported 2010-06-29 06:19:13 PDT
SVGRenderSupport contains the SVGRenderBase class, which was meant to be a base class for all SVG renders until all inherit from RenderSVGModelObject, introduced by Eric a year ago. RenderSVGModelObject inherits from RenderObject. That means classes like RenderSVGImage, which inherits from RenderImage, can NOT inherit from RenderSVGModelObject, as RenderImage already inherits from RenderObject. The whole class is uncessary and confusing. I'll rename it to SVGRenderSupport, just like the file name, and make all methods static and make it impossible to construct the class. This shrinks the size of all SVG renderers.
Attachments
Initial patch (68.79 KB, patch)
2010-06-29 07:05 PDT, Nikolas Zimmermann 		krit: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2010-06-29 07:05:23 PDT
Created attachment 60019 [details] Initial patch
WebKit Review Bot
Comment 2 2010-06-29 07:07:42 PDT
Attachment 60019 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/rendering/RenderSVGResourcePattern.cpp:28: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dirk Schulze
Comment 3 2010-06-29 07:17:48 PDT
Comment on attachment 60019 [details] Initial patch LGTM. Fix the alphabetic order and you can land it. r=me.
Nikolas Zimmermann
Comment 4 2010-06-29 07:26:28 PDT
Landed in r62117.
Nikolas Zimmermann
Comment 5 2010-06-29 07:27:34 PDT
Oops, that should be: 62118.
Note You need to log in before you can comment on or make changes to this bug.