Bug 41342 – Move PaintInfo/PaintPhase into their own headers, out of RenderObject

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Nikolas Zimmermann]

RenderObject is so cluttered, we could at least move PaintInfo / PaintPhase out of them, as a comment on top indicates.

[Nikolas Zimmermann]

Created attachment 60008 [details]
Initial patch

Very mechnic, just search/replace and a move.

[WebKit Review Bot]

Attachment 60008 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/rendering/RenderTheme.h:176:  More than one command on the same line  [whitespace/newline] [4]
WebCore/rendering/InlineTextBox.cpp:360:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
WebCore/rendering/InlineFlowBox.cpp:691:  _tx is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/rendering/InlineFlowBox.cpp:691:  _ty is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/rendering/InlineFlowBox.cpp:911:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 5 in 79 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Nikolas Zimmermann]

(In reply to comment #2)
> Attachment 60008 [details] did not pass style-queue:
> 
> Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
> WebCore/rendering/RenderTheme.h:176:  More than one command on the same line  [whitespace/newline] [4]
> WebCore/rendering/InlineTextBox.cpp:360:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
> WebCore/rendering/InlineFlowBox.cpp:691:  _tx is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
> WebCore/rendering/InlineFlowBox.cpp:691:  _ty is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
> WebCore/rendering/InlineFlowBox.cpp:911:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
> Total errors found: 5 in 79 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

These issues aren't introduced by the patch, they've been there before, and I have no plan to change any code there, besides the renames. So please bear with those issues :-)

[Dirk Schulze]

Comment on attachment 60008 [details]
Initial patch

r=me

[Nikolas Zimmermann]

Landed in r62104.