Bug 41338 - REGRESSION(62052): It broke --minimal build
Summary: REGRESSION(62052): It broke --minimal build
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Critical
Assignee: Nobody
Depends on: 41362
Blocks: 40484
  Show dependency treegraph
Reported: 2010-06-29 01:48 PDT by Csaba Osztrogonác
Modified: 2010-06-29 11:17 PDT (History)
3 users (show)

See Also:

Patch (1.63 KB, patch)
2010-06-29 04:29 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
Patch (1.77 KB, patch)
2010-06-29 05:11 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2010-06-29 01:48:49 PDT
http://trac.webkit.org/changeset/62052 broke --minimal build: 

../../../WebCore/bindings/js/ScriptEventListener.cpp:40:22: error: SVGNames.h: No such file or directory
../../../WebCore/bindings/js/ScriptEventListener.cpp: In function ‘WTF::PassRefPtr<WebCore::JSLazyEventListener> WebCore::createWindowAttributeEventListener(WebCore::Element*, WebCore::Attribute*)’:
../../../WebCore/bindings/js/ScriptEventListener.cpp:87: error: invalid use of incomplete type ‘struct WebCore::Element’
../../../WebCore/dom/Node.h:52: error: forward declaration of ‘struct WebCore::Element’
../../../WebCore/bindings/js/ScriptEventListener.cpp:110: error: no matching function for call to ‘WebCore::JSLazyEventListener::create(const WebCore::String&, const WebCore::String&, const WebCore::AtomicString&, WebCore::Element*&, WebCore::String&, int&, JSC::JSObject*&, WebCore::DOMWrapperWorld*)’
../../../WebCore/bindings/js/JSLazyEventListener.h:32: note: candidates are: static WTF::PassRefPtr<WebCore::JSLazyEventListener> WebCore::JSLazyEventListener::create(const WebCore::String&, const WebCore::String&, const WebCore::String&, WebCore::Node*, const WebCore::String&, int, JSC::JSObject*, WebCore::DOMWrapperWorld*)
Comment 1 Csaba Osztrogonác 2010-06-29 04:29:11 PDT
Created attachment 60006 [details]
Comment 2 Csaba Osztrogonác 2010-06-29 04:31:56 PDT
!ENABLE(SVG) case needs #include "Element.h"
Comment 3 Csaba Osztrogonác 2010-06-29 05:11:08 PDT
Created attachment 60010 [details]
Comment 4 Csaba Osztrogonác 2010-06-29 05:12:39 PDT
Comment on attachment 60010 [details]

Updated based on IRC discussing with Nikolas
Comment 5 Nikolas Zimmermann 2010-06-29 05:43:11 PDT
Comment on attachment 60010 [details]

Comment 6 Brady Eidson 2010-06-29 09:44:37 PDT
Sorry about this one guys.

The full Qt build has an EWS bot, which passed.  I would've fixed this if the minimal build also had EWS  ;)
Comment 7 WebKit Commit Bot 2010-06-29 10:04:01 PDT
Comment on attachment 60010 [details]

Clearing flags on attachment: 60010

Committed r62129: <http://trac.webkit.org/changeset/62129>
Comment 8 WebKit Commit Bot 2010-06-29 10:04:06 PDT
All reviewed patches have been landed.  Closing bug.