Bug 41303 - Need way more border-radius tests
Summary: Need way more border-radius tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-28 14:12 PDT by Beth Dakin
Modified: 2010-06-30 13:50 PDT (History)
2 users (show)

See Also:

Attachments
Interactive Test Case (1.61 KB, text/html)
2010-06-28 14:13 PDT, Beth Dakin 		no flags Details
New and improved interactive testcase (2.30 KB, text/html)
2010-06-29 13:18 PDT, Simon Fraser (smfr) 		no flags Details
New and improveder testcase (2.30 KB, text/html)
2010-06-29 13:23 PDT, Simon Fraser (smfr) 		no flags Details
Twenty tests (509.84 KB, patch)
2010-06-30 13:28 PDT, Beth Dakin 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2010-06-28 14:12:46 PDT 
http://trac.webkit.org/changeset/62035 introduced a new method of drawing border-radius using paths. Right now, this new code is only enabled for some platforms…if you want to know if your favorite platform has the new code path enabled, see if it has been added to #define HAVE_PATH_BASED_BORDER_RADIUS_DRAWING in RenderObject.h.

We need way more tests for border-radius. We could get some great ones based on the attached interactive test case that Dan made.
Comment 1 Beth Dakin 2010-06-28 14:13:41 PDT 
Created attachment 59939 [details]
Interactive Test Case
Comment 2 Simon Fraser (smfr) 2010-06-29 13:18:55 PDT 
Created attachment 60045 [details]
New and improved interactive testcase
Comment 3 Simon Fraser (smfr) 2010-06-29 13:23:37 PDT 
Created attachment 60046 [details]
New and improveder testcase
Comment 4 Beth Dakin 2010-06-30 13:28:21 PDT 
Created attachment 60145 [details]
Twenty tests

Here are 20 new tests, many of which are based on interesting snapshots found using the interactive test case.
Comment 5 Beth Dakin 2010-06-30 13:50:45 PDT 
Thanks Dan! Committed with r62200.