Bug 41302 - Drawing border-radius from path doesn't appear to always match up border edges correctly
Summary: Drawing border-radius from path doesn't appear to always match up border edge...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on: 58761
Blocks:
  Show dependency treegraph
 
Reported: 2010-06-28 14:09 PDT by Beth Dakin
Modified: 2011-04-19 11:47 PDT (History)
3 users (show)

See Also:


Attachments
Test case (454 bytes, text/html)
2010-06-28 14:09 PDT, Beth Dakin
no flags Details
Image explaining strategy for radius drawing (49.03 KB, image/png)
2010-06-28 14:10 PDT, Beth Dakin
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2010-06-28 14:09:45 PDT
Created attachment 59937 [details]
Test case

http://trac.webkit.org/changeset/62035 introduced a new method of drawing border-radius using paths. Right now, this new code is only enabled for some platforms…if you want to know if your favorite platform has the new code path enabled, see if it has been added to #define HAVE_PATH_BASED_BORDER_RADIUS_DRAWING in RenderObject.h.

I think there are some edge cases where we do not match up the radius edges as the W3C suggests. Attached is a test case demonstrating what I think is an incorrect rendering, and also a diagram demonstrating the correct rendering method.
Comment 1 Beth Dakin 2010-06-28 14:10:48 PDT
Created attachment 59938 [details]
Image explaining strategy for radius drawing
Comment 2 Jerry Seeger 2010-11-28 09:10:29 PST
Note that the radius strategy here does not conform to the CSS3 specification at http://www.w3.org/TR/css3-background/#corner-transitions

Specifically, the spec says "The center of color and style transitions between adjoining borders is at the point on the curve that is at an angle that is proportional to the ratio of the border widths."

I took a shot at interpreting just what the spec means at http://jerssoftwarehut.com/generalized-round-corner-diagram.xhtml
Comment 3 Simon Fraser (smfr) 2010-11-28 09:37:05 PST
I just read <http://jerssoftwarehut.com/generalized-round-corner-diagram.xhtml> (nice!).

I'd encourage you to send feedback to the www-style mailing list highlighting the issues you saw in the spec.
Comment 4 Simon Fraser (smfr) 2011-04-19 11:47:03 PDT
http://trac.webkit.org/changeset/84273