[V8] Catch toString() exceptions in all DB-related code in V8 bindings

[Dumitru Daniliuc]

V8Binding::v8NonStringValueToWebCoreString() suppresses the exceptions thrown by ToString() and returns an empty String. It shouldn't do that.

[Dumitru Daniliuc]

Created attachment 59991 [details]
patch

[Adam Barth]

Comment on attachment 59991 [details]
patch

Looks good.

WebCore/bindings/v8/custom/V8BindingMacros.h:35
 +          var = value;                      \
It's usually a good idea to put parenthesis around (value).  Otherwise you might get strange order-of-operations issues.

WebCore/bindings/v8/custom/V8BindingMacros.h:44
 +          v8::Handle<v8::String> v8String = value->ToString();               \
It's usually a good idea to put parenthesis around (value).  Otherwise you might get strange order-of-operations issues.

[Dumitru Daniliuc]

(In reply to comment #2)
> (From update of attachment 59991 [details])
> Looks good.
> 
> WebCore/bindings/v8/custom/V8BindingMacros.h:35
>  +          var = value;                      \
> It's usually a good idea to put parenthesis around (value).  Otherwise you might get strange order-of-operations issues.
> 
> WebCore/bindings/v8/custom/V8BindingMacros.h:44
>  +          v8::Handle<v8::String> v8String = value->ToString();               \
> It's usually a good idea to put parenthesis around (value).  Otherwise you might get strange order-of-operations issues.

good point! fixed.

[Dumitru Daniliuc]

Landed: r62094.

[WebKit Review Bot]

http://trac.webkit.org/changeset/62094 might have broken Qt Windows 32-bit Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/62093
http://trac.webkit.org/changeset/62094
http://trac.webkit.org/changeset/62095